Add $lookup aggregation stage tests#148
Open
danielfrankcom wants to merge 5 commits intodocumentdb:mainfrom
Open
Add $lookup aggregation stage tests#148danielfrankcom wants to merge 5 commits intodocumentdb:mainfrom
danielfrankcom wants to merge 5 commits intodocumentdb:mainfrom
Conversation
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
documentdb-triage-tool
Bot
added
compatibility test
|
🤖 Auto-triaged by documentdb-triage-tool. Applied: Reasoningcomponent from path globs (test-coverage, test-framework); effort from diff stats (8001+2 LOC, 23 files); LLM: Adds new test cases for the $lookup aggregation stage, including a new LookupTestCase class extending StageTestCase to handle foreign document references — new test coverage within one component, under 500 LOC. If a label is wrong, remove it manually and ping |
Remove LookupPrecedenceTestCase and message content assertions. Drop 4 test cases that relied on error message content to distinguish precedence. Remaining 6 cases use distinct error codes and follow the standard setup_lookup/build_lookup_command pattern. Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds tests for the
$lookupaggregation stage operator.As part of this change I had to add a new
LookupTestCaseclass which extendsStageTestCase, in order to deal with some complexity that is specific to this operator. The tests need a way to define and reference foreign documents, which means we need to create those documents as part of the test run, and replace a foreign reference sentinel is the actual pipeline definition.