Added index tests for $listIndexes#150
Open
vic-tsang wants to merge 1 commit intodocumentdb:mainfrom
Open
Conversation
Signed-off-by: Victor Tsang <vitsangp@amazon.com>
documentdb-triage-tool
Bot
added
compatibility test
|
🤖 Auto-triaged by documentdb-triage-tool. Applied: Reasoningcomponent from path globs (test-coverage, test-framework); effort from diff stats (1917+3 LOC, 10 files); LLM: Adds new index tests for $listIndexes command, expanding test coverage for an existing feature tracked in issue #27. If a label is wrong, remove it manually and ping |
manojnks
reviewed
Apr 30, 2026
| database_client.drop_collection(coll_name) | ||
|
|
||
|
|
||
| def test_listIndexes_timeseries_with_secondary(database_client): |
There was a problem hiding this comment.
listIndexes ordering is NOT guaranteed by spec. Use assertSuccessPartial or sort both sides — otherwise flaky.
Comment on lines
+211
to
+234
| def test_listIndexes_system_profile(database_client): | ||
| """Test listIndexes on system.profile collection returns empty firstBatch.""" | ||
| db = database_client | ||
| db.command({"profile": 2}) | ||
| try: | ||
| result = execute_command(db["system.profile"], {"listIndexes": "system.profile"}) | ||
| assertSuccess(result, []) | ||
| finally: | ||
| db.command({"profile": 0}) | ||
|
|
||
|
|
||
| def test_listIndexes_system_views(database_client): | ||
| """Test listIndexes on system.views collection returns _id index.""" | ||
| src_name = "test_sys_views_src" | ||
| database_client[src_name].insert_one({"_id": 1}) | ||
| database_client.create_collection("test_view_for_sys", viewOn=src_name, pipeline=[]) | ||
|
|
||
| try: | ||
| result = execute_command(database_client["system.views"], {"listIndexes": "system.views"}) | ||
| assertSuccess(result, [{"v": 2, "key": {"_id": 1}, "name": "_id_"}]) | ||
| finally: | ||
| database_client.drop_collection("test_view_for_sys") | ||
| database_client.drop_collection(src_name) | ||
|
|
There was a problem hiding this comment.
does clean up need db.system.profile.drop() this?
Comment on lines
+93
to
+106
| def test_listIndexes_omit_cursor_returns_all(collection_with_3_indexes): | ||
| """Test listIndexes without cursor field returns all indexes.""" | ||
| result = execute_command( | ||
| collection_with_3_indexes, {"listIndexes": collection_with_3_indexes.name} | ||
| ) | ||
|
|
||
| assertSuccess( | ||
| result, | ||
| [ | ||
| {"v": 2, "key": {"_id": 1}, "name": "_id_"}, | ||
| {"v": 2, "key": {"a": 1}, "name": "a_1"}, | ||
| {"v": 2, "key": {"b": 1}, "name": "b_1"}, | ||
| ], | ||
| ) |
| {"v": 2, "key": {"_id": 1}, "name": "_id_"}, | ||
| {"v": 2, "key": {"$**": 1}, "name": "wildcard"}, | ||
| ], | ||
| msg="Wildcard index should appear in listIndexes output", |
There was a problem hiding this comment.
missing wildcardProjection cases
test> db.test.createIndex({"$**":1},{"wildcardProjection":{a:1}})
$**_1
test> db.test.getIndexes()
[
{ v: 2, key: { _id: 1 }, name: '_id_' },
{
v: 2,
key: { '$**': 1 },
name: '$**_1',
wildcardProjection: { a: 1 }
}
]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains
Ref: