Skip to content

Add string operator $concat/$split tests#77

Open
eerxuan wants to merge 2 commits intodocumentdb:mainfrom
eerxuan:upstream-concat-split-tests
Open

Add string operator $concat/$split tests#77
eerxuan wants to merge 2 commits intodocumentdb:mainfrom
eerxuan:upstream-concat-split-tests

Conversation

@eerxuan
Copy link
Copy Markdown
Collaborator

@eerxuan eerxuan commented Apr 9, 2026

Add compatibility tests for the $concat and $split operators.

Ref: #10

Tests cover:

  • Core behavior and string values
  • Input forms and encoding
  • Type errors and invalid arguments
  • Null/missing handling
  • Size limits
  • Invariants
  • Usage patterns

322 tests total.

@eerxuan eerxuan requested a review from a team as a code owner April 9, 2026 23:36
@eerxuan eerxuan force-pushed the upstream-concat-split-tests branch from 77ca020 to 990e4bb Compare April 9, 2026 23:38
@eerxuan eerxuan force-pushed the upstream-concat-split-tests branch from 990e4bb to ed62757 Compare April 15, 2026 01:51
@documentdb-triage-tool documentdb-triage-tool Bot added compatibility test Compatibility test related enhancement New feature or request labels Apr 29, 2026
@documentdb-triage-tool
Copy link
Copy Markdown

🤖 Auto-triaged by documentdb-triage-tool.

Applied: compatibility test, enhancement
Project fields suggested: Component test-coverage · Priority P2 · Effort XL · Status Needs Review
Confidence: 0.90 (mixed)

Reasoning

component from path globs (test-coverage, test-framework, ci); effort from diff stats (2818+1 LOC, 28 files); LLM: Adds 322 new compatibility tests for $concat/$split string operators across multiple test categories, expanding coverage in documentdb_tests/compatibility/tests/.

If a label is wrong, remove it manually and ping @patty-chow so the rules can be tuned. The bot will not re-label items that already have component labels.

danielfrankcom and others added 2 commits April 30, 2026 12:27
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
- Add __init__.py for package resolution
- Add CONCAT_TYPE_ERROR, SPLIT_STRING_TYPE_ERROR, SPLIT_EMPTY_SEPARATOR_ERROR, SPLIT_DELIMITER_TYPE_ERROR, FAILED_TO_PARSE_ERROR, INVALID_DOLLAR_FIELD_PATH, BSON_TO_STRING_CONVERSION_ERROR, STRING_SIZE_LIMIT_ERROR to error_codes.py
- Add STRING_SIZE_LIMIT_BYTES to test_constants.py
- Fix pytest_params import (parametrize module)
- Use relative imports for operator common utils
- Pin CI MongoDB to 8.2.4
- Run isort/black formatting

Signed-off-by: Yunxuan Shi <yunxuan@amazon.com>
@eerxuan eerxuan force-pushed the upstream-concat-split-tests branch from ed62757 to b09bd47 Compare April 30, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compatibility test Compatibility test related enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants