Skip to content

#458 Added support to set MapFileExtensions#459

Merged
NikolaMilosavljevic merged 8 commits intodotnet:mainfrom
HakanL:main
Aug 26, 2025
Merged

#458 Added support to set MapFileExtensions#459
NikolaMilosavljevic merged 8 commits intodotnet:mainfrom
HakanL:main

Conversation

@HakanL
Copy link
Copy Markdown
Contributor

@HakanL HakanL commented May 15, 2025

I've added support for setting the deployment option MapFileExtensions via this tool and command line

@NikolaMilosavljevic
Copy link
Copy Markdown
Member

@HakanL help messages should also be updated to include the new command-line option. Check HelpTerse and HelpVerbose resources in Application.resx.

@HakanL
Copy link
Copy Markdown
Contributor Author

HakanL commented Aug 20, 2025

@NikolaMilosavljevic Makes sense, added!

@NikolaMilosavljevic
Copy link
Copy Markdown
Member

@NikolaMilosavljevic Makes sense, added!

Also, XLF files that were generated on your machine, during build should be included in the PR.

Specifies if the deployment manifest will include the deployment
provider URL.

-MapFileExtensions <true|false> -ip
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a copy/paste typo - the switch should be -mfe.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes, you're right, sorry.

@HakanL
Copy link
Copy Markdown
Contributor Author

HakanL commented Aug 20, 2025

Also, XLF files that were generated on your machine, during build should be included in the PR.

Ah, didn't know they were supposed to be included. Fixed.

Specifies if the deployment manifest will include the deployment
provider URL.

-MapFileExtensions <true|false> -mfe
Copy link
Copy Markdown
Member

@NikolaMilosavljevic NikolaMilosavljevic Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HakanL - one minor issue before I approve this PR. -MapFileExtentions option should be listed right above -MinVersion as options are listed alphabetically. This change will produce new XLF files.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, got it, fixed.

dotnet-maestro bot and others added 2 commits August 25, 2025 23:06
* Update dependencies from https://github.com/dotnet/dotnet build 279959
Updated Dependencies:
Microsoft.DotNet.Arcade.Sdk (Version 10.0.0-beta.25416.109 -> 10.0.0-beta.25418.119)

* Update dependencies from https://github.com/dotnet/dotnet build 280198
Updated Dependencies:
Microsoft.DotNet.Arcade.Sdk (Version 10.0.0-beta.25418.119 -> 10.0.0-beta.25420.109)

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Specifies whether or not the ".deploy" file extension mapping is used.
      If this flag is true then every application file is published with a
      ".deploy" file extension. This option is useful for web server security
      to limit the number of file extensions that need to be unblocked to
      enable ClickOnce application deployment. The default is false.
@HakanL HakanL requested a review from a team as a code owner August 26, 2025 06:06
Copy link
Copy Markdown
Member

@NikolaMilosavljevic NikolaMilosavljevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HakanL thank you for this contribution!

@NikolaMilosavljevic NikolaMilosavljevic merged commit 0a1e836 into dotnet:main Aug 26, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants