Skip to content

[dotnet] Add support for Mac Catalyst apps optimized interface for macOS. Fixes #14621.#14663

Merged
rolfbjarne merged 4 commits intodotnet:mainfrom
rolfbjarne:maccatalyst-optimize-interface-for-mac
Apr 7, 2022
Merged

[dotnet] Add support for Mac Catalyst apps optimized interface for macOS. Fixes #14621.#14663
rolfbjarne merged 4 commits intodotnet:mainfrom
rolfbjarne:maccatalyst-optimize-interface-for-mac

Conversation

@rolfbjarne
Copy link
Copy Markdown
Member

This also required bumping Xamarin.MacDev.

New commits in xamarin/Xamarin.MacDev:

Diff: https://github.com/xamarin/Xamarin.MacDev/compare/9e6e29f2a4e89b140cb37575168faccc70c45d5f..0717ac3c249595b48860904ce77000a6115affbe

Fixes #14621.

@rolfbjarne rolfbjarne added not-notes-worthy Ignore for release notes run-dotnet-tests Run all the .NET tests do-not-merge Do not merge this pull request labels Apr 5, 2022
@rolfbjarne

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@rolfbjarne rolfbjarne removed the do-not-merge Do not merge this pull request label Apr 6, 2022
@rolfbjarne rolfbjarne force-pushed the maccatalyst-optimize-interface-for-mac branch from 795f1c5 to a319cd7 Compare April 6, 2022 06:24
@rolfbjarne rolfbjarne force-pushed the maccatalyst-optimize-interface-for-mac branch from a319cd7 to d8ba40f Compare April 6, 2022 06:26
@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@rolfbjarne rolfbjarne marked this pull request as ready for review April 6, 2022 09:04
@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@emaf
Copy link
Copy Markdown
Contributor

emaf commented Apr 6, 2022

@rolfbjarne Do we need a new option for this in the VS/VSM Info.plist editors?

@rolfbjarne
Copy link
Copy Markdown
Member Author

@emaf that would probably be a good idea, yes

@rolfbjarne
Copy link
Copy Markdown
Member Author

The bug (#14621) contains a screenshot of Xcode's UI

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

❌ Tests on macOS Mac Catalina (10.15) failed ❌

Failed tests are:

  • linksdk

Pipeline on Agent
Merge b543187 into 6af4b96

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

❌ Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • introspection
  • linksdk
  • linkall

Pipeline on Agent
Merge b543187 into 6af4b96

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

❌ [CI Build] Tests failed on VSTS: simulator tests iOS ❌

Tests failed on VSTS: simulator tests iOS.

Test results

2 tests failed, 207 tests passed.

Failed tests

  • monotouch-test/Mac [dotnet]/Debug [dotnet]: Failed (Test run failed.
    Tests run: 2574 Passed: 2498 Inconclusive: 3 Failed: 1 Ignored: 75)
  • trimmode link/Mac [dotnet]/Release [dotnet]: Failed (Test run failed.
    Tests run: 117 Passed: 106 Inconclusive: 0 Failed: 1 Ignored: 10)

Pipeline on Agent XAMBOT-1105.Monterey
Merge b543187 into 6af4b96

@rolfbjarne
Copy link
Copy Markdown
Member Author

Test failures are unrelated:

@rolfbjarne rolfbjarne merged commit 1b37c48 into dotnet:main Apr 7, 2022
@rolfbjarne rolfbjarne deleted the maccatalyst-optimize-interface-for-mac branch April 7, 2022 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not-notes-worthy Ignore for release notes run-dotnet-tests Run all the .NET tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider supporting UIDeviceFamily 6

6 participants