[CoreBluetooth] Remove CBUUIDValidRangeString.#25270
Conversation
It's not available, and it's not in any public API, so we don't have to worry about API compatibility either.
There was a problem hiding this comment.
Pull request overview
Removes the internal CoreBluetooth binding for CBUUIDValidRangeString, which is not present in Apple’s public APIs, and cleans up related test/ignore entries.
Changes:
- Removed the internal
[Field ("CBUUIDValidRangeString")]binding fromCBUUIDinsrc/corebluetooth.cs. - Deleted corresponding skip logic in
tests/introspection/MacApiFieldTest.cs. - Removed the now-unnecessary xtro-sharpie ignore entry in
tests/xtro-sharpie/api-annotations-dotnet/macOS-CoreBluetooth.ignore.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/xtro-sharpie/api-annotations-dotnet/macOS-CoreBluetooth.ignore | Drops ignore for an internal binding that no longer exists. |
| tests/introspection/MacApiFieldTest.cs | Removes skip exceptions tied to the removed field. |
| src/corebluetooth.cs | Removes the internal CBUUIDValidRangeString field binding. |
✅ [PR Build #f55f410] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #f55f410] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #f55f410] Build passed (Build macOS tests) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #f55f410] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 156 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
It's not available, and it's not in any public API, so we don't have to worry
about API compatibility either.