Skip to content

[devops] Make the API diff pipeline use a pr: trigger.#25284

Merged
rolfbjarne merged 1 commit intomainfrom
dev/rolf/devops-no-pipeline-trigger-apidiff
Apr 30, 2026
Merged

[devops] Make the API diff pipeline use a pr: trigger.#25284
rolfbjarne merged 1 commit intomainfrom
dev/rolf/devops-no-pipeline-trigger-apidiff

Conversation

@rolfbjarne
Copy link
Copy Markdown
Member

Unfortunately Azure DevOps doesn't properly report GitHub checks for pipelines
triggered by another pipeline, when that other pipeline was triggered from a
pr trigger.

So go back to triggering the API diff pipeline using a pr: trigger.

This effectively reverts #21880 ("[CI] Make the API diff be triggered as soon as the config of the build is done.")

References:

Unfortunately Azure DevOps doesn't properly report GitHub checks for pipelines
triggered by another pipeline, when that other pipeline was triggered from a
pr trigger.

So go back to triggering the API diff pipeline using a pr: trigger.

This effectively reverts #21880 ("[CI] Make the API diff be triggered as soon as the config of the build is done.")

References:

* https://stackoverflow.com/questions/78443654/reporting-stage-statuses-to-github-for-pipeline-triggered-by-another-pipeline
Copilot AI review requested due to automatic review settings April 30, 2026 13:59
@rolfbjarne
Copy link
Copy Markdown
Member Author

rolfbjarne commented Apr 30, 2026

This is the same as #25238, just with the correct target branch.

Merging right away, since the original PR passed, was approved, and is identical to this one.

@rolfbjarne rolfbjarne merged commit eb40ec7 into main Apr 30, 2026
8 of 13 checks passed
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR switches the PR API diff pipeline back to using an Azure DevOps pr: trigger (instead of being triggered via a pipeline resource), in order to ensure GitHub check reporting works correctly for PRs.

Changes:

  • Replace the pipeline-resource-based trigger with an explicit pr: trigger for run-pr-api-diff.yml, including path exclusions to avoid running on doc-only changes.
  • Remove a trailing blank line at the end of the top-level Makefile.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tools/devops/automation/run-pr-api-diff.yml Reverts PR API diff pipeline to a direct PR trigger with path exclusions.
Makefile Removes trailing whitespace/blank line at EOF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants