Skip to content

Improve screen reader accessibility for Add button #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfversluis merged 4 commits into from
Aug 8, 2025
Merged

Improve screen reader accessibility for Add button #650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6706096
updated AddButton.xaml
Vignesh-SF3580 Aug 7, 2025
7746233
updated screen reader texts for add task and project button.
Vignesh-SF3580 Aug 7, 2025
4c0effe
updated AddButton.xaml
Vignesh-SF3580 Aug 7, 2025
8627d1b
Merge branch 'main' into fix-30810
jfversluis Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion 10.0/Apps/DeveloperBalance/Pages/MainPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@

<controls:AddButton
IsEnabled="{Binding IsBusy, Converter={StaticResource InvertedBoolConverter}}"
Command="{Binding AddTaskCommand}" />
Command="{Binding AddTaskCommand}"
SemanticProperties.Description="Add task" />
</Grid>
</ContentPage>
3 changes: 2 additions & 1 deletion 10.0/Apps/DeveloperBalance/Pages/ProjectDetailPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,8 @@
</VerticalStackLayout>
</ScrollView>

<controls:AddButton Command="{Binding AddTaskCommand}" />
<controls:AddButton Command="{Binding AddTaskCommand}"
SemanticProperties.Description="Add task" />
</Grid>

</ContentPage>
3 changes: 2 additions & 1 deletion 10.0/Apps/DeveloperBalance/Pages/ProjectListPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
</ScrollView>

<controls:AddButton
Command="{Binding AddProjectCommand}" />
Command="{Binding AddProjectCommand}"
SemanticProperties.Description="Add project" />
</Grid>
</ContentPage>
3 changes: 2 additions & 1 deletion 9.0/Apps/DeveloperBalance/Pages/MainPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@

<controls:AddButton
IsEnabled="{Binding IsBusy, Converter={StaticResource InvertedBoolConverter}}"
Command="{Binding AddTaskCommand}" />
Command="{Binding AddTaskCommand}"
SemanticProperties.Description="Add task" />
</Grid>
</ContentPage>
3 changes: 2 additions & 1 deletion 9.0/Apps/DeveloperBalance/Pages/ProjectDetailPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,8 @@
</VerticalStackLayout>
</ScrollView>

<controls:AddButton Command="{Binding AddTaskCommand}" />
<controls:AddButton Command="{Binding AddTaskCommand}"
SemanticProperties.Description="Add task" />
</Grid>

</ContentPage>
3 changes: 2 additions & 1 deletion 9.0/Apps/DeveloperBalance/Pages/ProjectListPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
</CollectionView>

<controls:AddButton
Command="{Binding AddProjectCommand}" />
Command="{Binding AddProjectCommand}"
SemanticProperties.Description="Add project" />
</Grid>
</ContentPage>
Loading