Fix Selected Tags Not Restored on MainPage After Navigation#686
Merged
jfversluis merged 5 commits intodotnet:mainfrom Oct 7, 2025
Merged
Fix Selected Tags Not Restored on MainPage After Navigation#686jfversluis merged 5 commits intodotnet:mainfrom
jfversluis merged 5 commits intodotnet:mainfrom
Conversation
jsuarezruiz
reviewed
Oct 6, 2025
| { | ||
| await _tagRepository.DeleteItemAsync(tag, _project.ID); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Needs to update SelectedTags to reflect current selection?
SelectedTags = new List<object>(currentSelection);
Contributor
Author
There was a problem hiding this comment.
@jsuarezruiz Yes, I have updated the SelectedTags in SelectionChanged as suggested, it now reflects the current selection immediately when tags are selected.
Contributor
|
This PR fixes dotnet/maui#30749 |
jfversluis
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Detail
Selected tags are not restored on MainPage after returning from ProjectDetailPage.
Root Cause
After the changes introduced in PR-611, when a tag was initially selected, navigating to ProjectDetailPage caused it to be deleted in the ToggleTag method through the SelectionChanged logic. This incorrect logic resulted in the selected tags being lost on the MainPage.
Description of Change
Updated SelectionChanged command logic that compares the current selection with the previous one, updates the IsSelected property for newly selected or deselected tags, and saves the changes to keep the selection state consistent across navigation.
Breaking changes: https://github.com/dotnet/maui-samples/pull/611/files#diff-cbae54bfccffc3323ca041b37c3e9be2c5515d8aa51ced752b277d5744eb3591
Break PR: #611
Screenshots
BeforeFix.mov
AfterFix.mov