Fix BindingAdapterPosition Exception#22676
Merged
jfversluis merged 5 commits intodotnet:mainfrom Dec 12, 2024
Merged
Conversation
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
added
the
area-controls-collectionview
Member
|
@BaY1251 can you add a UITest for this? |
Contributor
Added UITest |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
Author
|
@jsuarezruiz |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
Author
|
Is IOS having this issue? |
Contributor
Author
|
@jsuarezruiz May I try testing only on the Android platform? |
|
Commenter does not have sufficient privileges for PR 22676 in repo dotnet/maui |
Contributor
Author
|
Someone can solve the problem of failing the test? |
Member
|
/rebase |
Member
|
@BaY1251 yes you can add the test only as android one |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This comment was marked as off-topic.
This comment was marked as off-topic.
Member
|
/rebase |
Contributor
Author
|
This is just a temporary solution. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Member
|
/azp run |
This comment was marked as outdated.
This comment was marked as outdated.
jfversluis
force-pushed
the
Fix-BindingAdapterPosition-Exception-1
branch
from
8d5e1c0 to
42dd0f2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
Azure Pipelines successfully started running 3 pipeline(s). |
jfversluis
approved these changes
Dec 12, 2024
samhouts
added
fixed-in-net9.0-nightly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
When BindingAdapterPosition is -1, an exception will be thrown.
The correct handling should be to determine this value.
Issues Fixed
Fixes #22674
Fixes #20764