Skip to content

[iOS] Set height for EmptyView if is not an IView#26680

Merged
PureWeen merged 4 commits intomainfrom
fix-26663
Dec 19, 2024
Merged

[iOS] Set height for EmptyView if is not an IView#26680
PureWeen merged 4 commits intomainfrom
fix-26663

Conversation

@rmarinho
Copy link
Copy Markdown
Member

@rmarinho rmarinho commented Dec 17, 2024

Description of Change

We introduced some calculations for when EmptyView is a IView, but the user can just provide a string as the EmptyView and that will be rendered as UILabel on iOS.
By setting by default the CollectionView.Height we keep the old behaviour.

Issues Fixed

Fixes #26663

@rmarinho rmarinho added area-controls-collectionview CollectionView, CarouselView, IndicatorView i/regression This issue described a confirmed regression on a currently supported version labels Dec 17, 2024
@rmarinho rmarinho added this to the .NET 9 SR3 milestone Dec 17, 2024
@rmarinho rmarinho requested a review from a team as a code owner December 17, 2024 14:13
@samhouts samhouts requested a review from Copilot December 17, 2024 17:56
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25551.cs:11

  • The namespace was changed from 'Microsoft.Maui.TestCases.Tests.Tests.Issues' to 'Microsoft.Maui.TestCases.Tests.Issues'. Verify if this change aligns with the project's namespace conventions.
namespace Microsoft.Maui.TestCases.Tests.Issues

@samhouts samhouts requested a review from Copilot December 17, 2024 17:59
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

@rmarinho rmarinho changed the title [iOS] Set height for EmptyView if is not an iView [iOS] Set height for EmptyView if is not an IView Dec 18, 2024
@PureWeen PureWeen self-assigned this Dec 18, 2024
@PureWeen PureWeen merged commit d57502f into main Dec 19, 2024
@PureWeen PureWeen deleted the fix-26663 branch December 19, 2024 23:17
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-collectionview CollectionView, CarouselView, IndicatorView i/regression This issue described a confirmed regression on a currently supported version

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[MAUI] I5_ EmptyView - No string is shown in the three 'EmptyView String' pages

3 participants