[Windows] Fixed IsEnabled Property not works on Tabs by NirmalKumarYuvaraj · Pull Request #26728 · dotnet/maui

NirmalKumarYuvaraj · 2024-12-19T14:30:39Z

Issue Details

In the Shell, when the Tab.isEnabled property is set to false, the tab should be non-interactive and prevent user interaction. the current behavior allows the tab to be clicked.

Root Cause

In Windows, implementation property for IsEnabled property is not handled.

Description of change

For the Windows platform, a new IsEnabled property was introduced in NavigationViewItemViewModel and registered within NavigationViewItem in the TabbedPageXaml.Windows page. The BaseShellItem.IsEnabled property is now mapped to this newly added property in the view model. Additionally, support was added to handle runtime updates by responding to property-changed events, ensuring the enabled state reflects changes dynamically.

Validated the Behavior in the following Platforms

Android
iOS
mac
WinUI

Issue fixed

Fixes #5161
Fixes #32996

Screenshots

Before Issue Fix	After Issue Fix
BeforeFix_5161.mp4	AfterFix_5161.mp4

Redth · 2025-01-02T17:24:54Z

/azp run

StephaneDelcroix · 2025-01-10T08:18:14Z

/azp run

azure-pipelines · 2025-01-10T13:15:08Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-01-20T11:47:16Z

/rebase

jsuarezruiz · 2025-01-20T11:48:09Z

/azp run

StephaneDelcroix · 2025-01-21T14:45:11Z

/azp run

azure-pipelines · 2025-01-31T16:09:00Z

Azure Pipelines successfully started running 3 pipeline(s).

rmarinho

Some little changes, we try not use the private keyword, also we try to use the brackets for making sure we don't missing something that should be in the if statement.

When making the changes please rebase on top of main too.

azure-pipelines · 2025-02-09T20:02:48Z

Azure Pipelines successfully started running 3 pipeline(s).

This reverts commit 369097d.

Dhivya-SF4094 · 2026-02-23T05:05:14Z

@NirmalKumarYuvaraj looks like this is probably already fixed by #33369 and or #33337 can you confirm?

@jfversluis I have validated this PR against the latest main after the recent iOS changes were merged.
The issue is now fully resolved on the iOS platform by the merged PR, so the iOS-specific changes included in this PR are no longer required.
However, I re-verified the behavior on the Windows platform, and the issue still reproduces there. The Windows fix included in this PR is still necessary and works as expected.

### Issue Details In the Shell, when the Tab.isEnabled property is set to false, the tab should be non-interactive and prevent user interaction. the current behavior allows the tab to be clicked. ### Root Cause In Windows, implementation property for IsEnabled property is not handled. ### Description of change For the Windows platform, a new IsEnabled property was introduced in NavigationViewItemViewModel and registered within NavigationViewItem in the TabbedPageXaml.Windows page. The BaseShellItem.IsEnabled property is now mapped to this newly added property in the view model. Additionally, support was added to handle runtime updates by responding to property-changed events, ensuring the enabled state reflects changes dynamically. ### Validated the Behavior in the following Platforms - [ ] Android - [ ] iOS - [ ] mac - [x] WinUI ### Issue fixed Fixes #5161 Fixes #32996 ### Screenshots | Before Issue Fix | After Issue Fix | |--|--| |<video src="https://github.com/user-attachments/assets/26173aef-ec99-4549-b88d-7e0a6f629052">|<video src='https://github.com/user-attachments/assets/a4eada5e-c5e7-4a0f-b312-af131813d4bf'>| --------- Co-authored-by: Dhivya-SF4094 <127717131+Dhivya-SF4094@users.noreply.github.com>

### Issue Details In the Shell, when the Tab.isEnabled property is set to false, the tab should be non-interactive and prevent user interaction. the current behavior allows the tab to be clicked. ### Root Cause In Windows, implementation property for IsEnabled property is not handled. ### Description of change For the Windows platform, a new IsEnabled property was introduced in NavigationViewItemViewModel and registered within NavigationViewItem in the TabbedPageXaml.Windows page. The BaseShellItem.IsEnabled property is now mapped to this newly added property in the view model. Additionally, support was added to handle runtime updates by responding to property-changed events, ensuring the enabled state reflects changes dynamically. ### Validated the Behavior in the following Platforms - [ ] Android - [ ] iOS - [ ] mac - [x] WinUI ### Issue fixed Fixes dotnet#5161 Fixes dotnet#32996 ### Screenshots | Before Issue Fix | After Issue Fix | |--|--| |<video src="https://github.com/user-attachments/assets/26173aef-ec99-4549-b88d-7e0a6f629052">|<video src='https://github.com/user-attachments/assets/a4eada5e-c5e7-4a0f-b312-af131813d4bf'>| --------- Co-authored-by: Dhivya-SF4094 <127717131+Dhivya-SF4094@users.noreply.github.com>

### Issue Details In the Shell, when the Tab.isEnabled property is set to false, the tab should be non-interactive and prevent user interaction. the current behavior allows the tab to be clicked. ### Root Cause In Windows, implementation property for IsEnabled property is not handled. ### Description of change For the Windows platform, a new IsEnabled property was introduced in NavigationViewItemViewModel and registered within NavigationViewItem in the TabbedPageXaml.Windows page. The BaseShellItem.IsEnabled property is now mapped to this newly added property in the view model. Additionally, support was added to handle runtime updates by responding to property-changed events, ensuring the enabled state reflects changes dynamically. ### Validated the Behavior in the following Platforms - [ ] Android - [ ] iOS - [ ] mac - [x] WinUI ### Issue fixed Fixes #5161 Fixes #32996 ### Screenshots | Before Issue Fix | After Issue Fix | |--|--| |<video src="https://github.com/user-attachments/assets/26173aef-ec99-4549-b88d-7e0a6f629052">|<video src='https://github.com/user-attachments/assets/a4eada5e-c5e7-4a0f-b312-af131813d4bf'>| --------- Co-authored-by: Dhivya-SF4094 <127717131+Dhivya-SF4094@users.noreply.github.com>

@Dhivya-SF4094

## What's Coming .NET MAUI inflight/candidate introduces significant improvements across all platforms with focus on quality, performance, and developer experience. This release includes 46 commits with various improvements, bug fixes, and enhancements. ## Button - [Android] Implemented material3 support for Button by @Dhivya-SF4094 in #33173 <details> <summary>🔧 Fixes</summary> - [Implement Material3 support for Button](#33172) </details> ## CollectionView - [Android] Fix RemainingItemsThresholdReachedCommand not firing when CollectionView has Header and Footer both defined by @SuthiYuvaraj in #29618 <details> <summary>🔧 Fixes</summary> - [Android : RemainingItemsThresholdReachedCommand not firing when CollectionVew has Header and Footer both defined](#29588) </details> - [iOS/MacCatalyst] Fix CollectionView ScrollTo for horizontal layouts by @Shalini-Ashokan in #33853 <details> <summary>🔧 Fixes</summary> - [[iOS/MacCatalyst] CollectionView ScrollTo does not work with horizontal Layout](#33852) </details> - [iOS & Mac] Fixed IndicatorView Size doesnt update dynamically by @SubhikshaSf4851 in #31129 <details> <summary>🔧 Fixes</summary> - [[iOS, Catalyst] IndicatorView.IndicatorSize does not update dynamically at runtime](#31064) </details> - [Android] Fix for CollectionView Scrolled event is triggered on the initial app load. by @BagavathiPerumal in #33558 <details> <summary>🔧 Fixes</summary> - [[Android] CollectionView Scrolled event is triggered on the initial app load.](#33333) </details> - [iOS, Android] Fix for CollectionView IsEnabled=false allows touch interactions by @praveenkumarkarunanithi in #31403 <details> <summary>🔧 Fixes</summary> - [More issues with CollectionView IsEnabled, InputTransparent, Opacity via Styles and code behind](#19771) </details> - [iOS] Fix VerticalOffset Update When Modifying CollectionView.ItemsSource While Scrolled by @devanathan-vaithiyanathan in #34153 <details> <summary>🔧 Fixes</summary> - [[iOS]VerticalOffset Not Reset to Zero After Clearing ItemSource in CollectionView](#26798) </details> ## DateTimePicker - [Android] Fix DatePicker MinimumDate/MaximumDate not updating dynamically by @HarishwaranVijayakumar in #33687 <details> <summary>🔧 Fixes</summary> - [[regression/8.0.3] [Android] DatePicker control minimum date issue](#19256) - [[Android] DatePicker does not update MinimumDate / MaximumDate in the Popup when set in the viewmodel after first opening](#33583) </details> ## Drawing - Android drawable perf by @albyrock87 in #31567 ## Editor - [Android] Implemented material3 support for Editor by @SyedAbdulAzeemSF4852 in #33478 <details> <summary>🔧 Fixes</summary> - [Implement Material3 Support for Editor](#33476) </details> ## Entry - [iOS, Mac] Fix for CursorPosition not updating when typing into Entry control by @SyedAbdulAzeemSF4852 in #30505 <details> <summary>🔧 Fixes</summary> - [Entry control CursorPosition does not update on TextChanged event [iOS Maui 8.0.7] ](#20911) - [CursorPosition not calculated correctly on behaviors events for iOS devices](#32483) </details> ## Flyoutpage - [Android, Windows] Fix for FlyoutPage toolbar button not updating on orientation change by @praveenkumarkarunanithi in #31962 <details> <summary>🔧 Fixes</summary> - [Flyout page in Android does not show flyout button (burger) consistently](#24468) </details> - Fix for First Item in CollectionView Overlaps in FlyoutPage.Flyout on iOS by @praveenkumarkarunanithi in #29265 <details> <summary>🔧 Fixes</summary> - [[iOS] CollectionView not rendering first item correctly in FlyoutPage.Flyout](#29170) </details> ## Image - [Android] Fix excessive memory usage for stream and resource-based image loading by @Shalini-Ashokan in #33590 <details> <summary>🔧 Fixes</summary> - [[Android] Unexpected high Bitmap.ByteCount when loading image via ImageSource.FromResource() or ImageSource.FromStream() in .NET MAUI](#33239) </details> - [Android] Fix for Resize method returns an image that has already been disposed by @SyedAbdulAzeemSF4852 in #29964 <details> <summary>🔧 Fixes</summary> - [In GraphicsView, the Resize method returns an image that has already been disposed](#29961) - [IIMage.Resize bugged behaviour](#31103) </details> ## Label - Fixed Label Span font property inheritance when applied via Style by @SubhikshaSf4851 in #34110 <details> <summary>🔧 Fixes</summary> - [`Span` does not inherit text styling from `Label` if that styling is applied using `Style` ](#21326) </details> - [Android] Implemented material3 support for Label by @SyedAbdulAzeemSF4852 in #33599 <details> <summary>🔧 Fixes</summary> - [Implement Material3 Support for Label](#33598) </details> ## Map - [Android] Fix Circle Stroke color is incorrectly updated as Fill color. by @NirmalKumarYuvaraj in #33643 <details> <summary>🔧 Fixes</summary> - [[Android] Circle Stroke color is incorrectly updated as Fill color.](#33642) </details> ## Mediapicker - [iOS] Fix: invoke MediaPicker completion handler after DismissViewController by @yuriikyry4enko in #34250 <details> <summary>🔧 Fixes</summary> - [[iOS] Media Picker UIImagePickerController closing issue](#21996) </details> ## Navigation - Fix ContentPage memory leak on Android when using NavigationPage modally (fixes #33918) by @brunck in #34117 <details> <summary>🔧 Fixes</summary> - [[Android] Modal TabbedPage whose tabs are NavigationPage(ContentPage) is retained after PopModalAsync()](#33918) </details> ## Picker - [Android] Implement material3 support for TimePicker by @HarishwaranVijayakumar in #33646 <details> <summary>🔧 Fixes</summary> - [Implement Material3 support for TimePicker](#33645) </details> - [Android] Implemented Material3 support for Picker by @SyedAbdulAzeemSF4852 in #33668 <details> <summary>🔧 Fixes</summary> - [Implement Material3 support for Picker](#33665) </details> ## RadioButton - [Android] Implemented material3 support for RadioButton by @SyedAbdulAzeemSF4852 in #33468 <details> <summary>🔧 Fixes</summary> - [Implement Material3 Support for RadioButton](#33467) </details> ## Setup - Clarify MA003 error message by @jeremy-visionaid in #34067 <details> <summary>🔧 Fixes</summary> - [MA003 false positive with 9.0.21](#26599) </details> ## Shell - [Android] Fix TabBar FlowDirection not updating dynamically by @SubhikshaSf4851 in #33091 <details> <summary>🔧 Fixes</summary> - [[Android, iOS] FlowDirection RTL is not updated dynamically on Shell TabBar](#32993) </details> - [Android] Fix page not disposed on Shell replace navigation by @Vignesh-SF3580 in #33426 <details> <summary>🔧 Fixes</summary> - [[Android] [Shell] replace navigation leaks current page](#25134) </details> - [Android] Fixed Shell flyout does not disable scrolling when FlyoutVerticalScrollMode is set to Disabled by @NanthiniMahalingam in #32734 <details> <summary>🔧 Fixes</summary> - [[Android] Shell.FlyoutVerticalScrollMode="Disabled" does not disable scrolling](#32477) </details> ## Single Project - Fix: Throw a clear error when an SVG lacks dimensions instead of a NullReferenceException by @Shalini-Ashokan in #33194 <details> <summary>🔧 Fixes</summary> - [MAUI Fails To Convert Valid SVG Files Into PNG Files (Object reference not set to an instance of an object)](#32460) </details> ## SwipeView - [iOS] Fix SwipeView stays open on iOS after updating content by @devanathan-vaithiyanathan in #31248 <details> <summary>🔧 Fixes</summary> - [[iOS] - Swipeview with collectionview issue](#19541) </details> ## TabbedPage - [Windows] Fixed IsEnabled Property not works on Tabs by @NirmalKumarYuvaraj in #26728 <details> <summary>🔧 Fixes</summary> - [ShellContent IsEnabledProperty does not work](#5161) - [[Windows] Shell Tab IsEnabled Not Working](#32996) </details> - [Android] Fix NavigationBar overlapping StatusBar when NavigationBar visibility changes by @Vignesh-SF3580 in #33359 <details> <summary>🔧 Fixes</summary> - [[Android] NavigationBar overlaps with StatusBar when mixing HasNavigationBar=true/false in TabbedPage on Android 15 (API 35)](#33340) </details> ## Templates - Fix for unable to open task using keyboard navigation on windows platform by @SuthiYuvaraj in #33647 <details> <summary>🔧 Fixes</summary> - [Unable to open task using keyboard: A11y_.NET maui_User can get all the insights of Dashboard_Keyboard](#30787) </details> ## TitleView - Fix for NavigationPage.TitleView does not expand with host window in iPadOS 26+ by @SuthiYuvaraj in #33088 ## Toolbar - [iOS] Fix toolbar items ignoring BarTextColor on iOS/MacCatalyst 26+ by @Shalini-Ashokan in #34036 <details> <summary>🔧 Fixes</summary> - [[iOS 26] ToolbarItem color with custom BarTextColor not working](#33970) </details> - [Android] Fix for ToolbarItem retaining the icon from the previous page on Android when using NavigationPage. by @BagavathiPerumal in #32311 <details> <summary>🔧 Fixes</summary> - [Toolbaritem keeps the icon of the previous page on Android, using NavigationPage (not shell)](#31727) </details> ## WebView - [Android] Fix WebView in a grid expands beyond it's cell by @devanathan-vaithiyanathan in #32145 <details> <summary>🔧 Fixes</summary> - [Android - WebView in a grid expands beyond it's cell](#32030) </details> ## Xaml - ContentPresenter: Propagate binding context to children with explicit TemplateBinding by @HarishwaranVijayakumar in #30880 <details> <summary>🔧 Fixes</summary> - [Binding context in ContentPresenter](#23797) </details> <details> <summary>🔧 Infrastructure (1)</summary> - [Revert] ContentPresenter: Propagate binding context to children with explicit TemplateBinding by @Ahamed-Ali in #34332 </details> <details> <summary>🧪 Testing (6)</summary> - [Testing] Feature Matrix UITest Cases for Shell Flyout Page by @NafeelaNazhir in #32525 - [Testing] Feature Matrix UITest Cases for Brushes by @LogishaSelvarajSF4525 in #31833 - [Testing] Feature Matrix UITest Cases for BindableLayout by @LogishaSelvarajSF4525 in #33108 - [Android] Add UI tests for Material 3 CheckBox by @HarishwaranVijayakumar in #34126 <details> <summary>🔧 Fixes</summary> - [[Android] Add UI tests for Material 3 CheckBox](#34125) </details> - [Testing] Feature Matrix UITest Cases for Shell Tabbed Page by @NafeelaNazhir in #33159 - [Testing] Fixed Test case failure in PR 34294 - [03/2/2026] Candidate - 1 by @TamilarasanSF4853 in #34334 </details> <details> <summary>📦 Other (2)</summary> - Bumps Syncfusion.Maui.Toolkit dependency to version 1.0.9 by @PaulAndersonS in #34178 - Fix crash when closing Windows based app when using TitleBar by @MFinkBK in #34032 <details> <summary>🔧 Fixes</summary> - [Unhandled exception "Value does not fall within the expected range" when closing Windows app](#32194) </details> </details> **Full Changelog**: main...inflight/candidate

dotnet-policy-service Bot added the community ✨ Community Contribution label Dec 19, 2024

sheiksyedm added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Dec 19, 2024

NirmalKumarYuvaraj marked this pull request as ready for review December 20, 2024 11:59

NirmalKumarYuvaraj requested a review from a team as a code owner December 20, 2024 11:59

NirmalKumarYuvaraj requested review from StephaneDelcroix and tj-devel709 December 20, 2024 11:59

PureWeen added the area-controls-tabbedpage TabbedPage label Dec 20, 2024

This comment was marked as outdated.

Sign in to view

MartyIX reviewed Jan 2, 2025

View reviewed changes

Comment thread src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue5161.cs Outdated

This comment was marked as off-topic.

Sign in to view

StephaneDelcroix reviewed Jan 10, 2025

View reviewed changes

Comment thread src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellItemRenderer.cs Outdated

This comment was marked as outdated.

Sign in to view

github-actions Bot force-pushed the fix-5161 branch from 2f4d28b to b984797 Compare January 20, 2025 11:47

This comment was marked as outdated.

Sign in to view

StephaneDelcroix previously approved these changes Jan 21, 2025

View reviewed changes

This comment was marked as outdated.

Sign in to view

github-actions Bot force-pushed the fix-5161 branch from b984797 to 3de2419 Compare January 31, 2025 16:06

rmarinho requested changes Feb 5, 2025

View reviewed changes

Comment thread src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellItemRenderer.cs Outdated

Comment thread src/Controls/src/Core/Handlers/Shell/ShellItemHandler.Windows.cs Outdated

Comment thread src/Controls/src/Core/Handlers/Shell/ShellItemHandler.Windows.cs

Dhivya-SF4094 dismissed StephaneDelcroix’s stale review via 2cb1253 February 5, 2025 13:30

Dhivya-SF4094 added 11 commits February 23, 2026 08:59

Updated the code as loop starts from 0

6a99f63

Fixed IsEnabled Property is not works for Tab

b8de19e

Modified Test case and Optimized code for runtime changes for WinUI

45d6a49

Modified test cases

8a46930

Revert "Modified test cases"

70c94c7

This reverts commit 369097d.

Updated the code as loop starts from 0

3f48328

Removed unwanted keyword

94fa4bb

Included the removed test sample

b55e98d

Updated ShellItemHandler.Windows

23ac384

Fixed CI failure

e9f188a

Fixed CI failure for windows platform

131219b

Dhivya-SF4094 force-pushed the fix-5161 branch from 9cd908a to 131219b Compare February 23, 2026 05:03

Reverted iOS fix; already addressed in PR dotnet#33369.

8f70cce

Dhivya-SF4094 changed the title ~~Fixed IsEnabled Property not works on Tabs~~ [Windows] Fixed IsEnabled Property not works on Tabs Feb 23, 2026

jfversluis changed the base branch from main to inflight/current February 23, 2026 15:51

jfversluis approved these changes Feb 23, 2026

View reviewed changes

jfversluis merged commit 2b2580c into dotnet:inflight/current Feb 23, 2026
17 of 27 checks passed

jfversluis added this to the .NET 10 SR5 milestone Feb 23, 2026

PureWeen mentioned this pull request Mar 9, 2026

March 2, 2026 Candidate Branch #34294

Merged

github-actions Bot locked and limited conversation to collaborators Mar 26, 2026

PureWeen modified the milestones: .NET 10 SR5, .NET 10 SR6 Apr 29, 2026

Conversation

NirmalKumarYuvaraj commented Dec 19, 2024 • edited by Dhivya-SF4094 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue Details

Root Cause

Description of change

Validated the Behavior in the following Platforms

Issue fixed

Screenshots

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

Redth commented Jan 2, 2025 • edited by jfversluis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as off-topic.

Uh oh!

StephaneDelcroix commented Jan 10, 2025 • edited by jfversluis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

azure-pipelines Bot commented Jan 10, 2025

Uh oh!

jsuarezruiz commented Jan 20, 2025

Uh oh!

jsuarezruiz commented Jan 20, 2025

Uh oh!

This comment was marked as outdated.

StephaneDelcroix commented Jan 21, 2025 • edited by jfversluis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

azure-pipelines Bot commented Jan 31, 2025

Uh oh!

rmarinho left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azure-pipelines Bot commented Feb 9, 2025

Uh oh!

Dhivya-SF4094 commented Feb 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

NirmalKumarYuvaraj commented Dec 19, 2024 •

edited by Dhivya-SF4094

Loading

Redth commented Jan 2, 2025 •

edited by jfversluis

Loading

StephaneDelcroix commented Jan 10, 2025 •

edited by jfversluis

Loading

StephaneDelcroix commented Jan 21, 2025 •

edited by jfversluis

Loading