[2025/05/26] Candidate - In Flight Branch#29623
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces new CarouselView feature pages to the TestCases.HostApp, updates the gallery pages, refines layout constraint computation in several layout classes, and adjusts handler mappings in Shell and related components in support of the inflight branch process.
- Adds new XAML and code-behind pages for CarouselView options, feature, and control views.
- Integrates CarouselView into the gallery and updates related animations, layout constraints, and event bindings.
- Enhances unit tests (e.g., ImageSource parent clearing) and adjusts platform-specific handler mappings.
Reviewed Changes
Copilot reviewed 106 out of 106 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| CarouselViewOptionsPage.xaml | New XAML page for CarouselView options UI. |
| CarouselViewFeaturePage.xaml & .xaml.cs | New feature page for demonstrating CarouselView usage. |
| CarouselViewControlPage.xaml & .xaml.cs | Implements CarouselView control with associated event handlers and binding integration. |
| CorePageView.cs | Registers the new CarouselView feature in the gallery page list. |
| ImageSourceTests.cs | Introduces a unit test to verify parent clearing when the image source is updated. |
| AssemblyInfo.cs | Adds internals visibility for Maui.UnitTests. |
| ModalNavigationManager.Android.cs | Refines modal navigation animation and dismissal handling. |
| FormattedStringExtensions.cs | Updates font span creation to use an updated font size retrieval method. |
| VerticalStackLayout.cs, StackLayout.cs, HorizontalStackLayout.cs, Grid.cs | Adds ComputeConstraintForView implementations to support fixed layout constraints. |
| ImageElement.cs | Modifies event attachment to use pattern matching for null checks. |
| ShellHandler.cs & ShellHandler.Windows.cs | Maps new Shell properties related to Flyout background images. |
| CarouselViewHandler.Windows.cs | Calls UpdateItemsSource for CarouselView template updates. |
| SearchHandlerAppearanceTracker.cs | Adjusts background color assignment on iOS search bar. |
| ShellToolbarTracker.cs | Updates toolbar item tint color handling with a new helper method. |
Contributor
Contributor
This was referenced May 27, 2025
Contributor
|
@sheiksyedm I've created PRs which fix these problems |
Contributor
Member
|
/rebase |
…nges (#29424) * Added FeatureTests for CollectionView * changes updated * changes updated
* Fixed picker title's color * Update PickerExtensions.cs
* [iOS] Setting background color on the Searchbar (#23325) * Added a test category * Ui tests * Update SearchHandlerAppearanceTracker.cs * Update Issue23325Test.png
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ion - 18 (#28033) * Enabled CollectionViewUITests * Updated Issue Link * Addressed Feedbacks * Updated changes * Added images * Revert Changes * Changes updated * updated changes * Changes updated * Changes updated * Reverted Issue18896 * Changes updated * Reverted issue1583_1 * Reverted Issue18896
* Don't LoadUrl call when source is null * Add UI Test * remove space * Update UI Test
* [iOS] ScrollView content offset RTL fix * Added a UITest
* Fixed incorrect width and height * Updated test sample * Updated method name * Update shared test sample * Given width and height request for graphicsview in sample * Added snapshots
* Fixed the item template dynamic changes * Added a test case * Added test case and added snapshots * committed the image * committed the image
* re-enabled the test for android * modified test case * Update src/Controls/tests/TestCases.HostApp/Issues/CarouselViewLoopNoFreeze.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
) * [Windows] Fix for FlyoutBackgroundImage * [Windows] Fix for Flyout Background Image * Test case sample for FlyoutBackgroundImage * [Windows] Fix for FlyoutBackgroundImage * [Windows] Fix for FlyoutBackgroundImage * Updated Test sample * Changed test sample and added snapshots for android and iOS * BackgroundImage set Snapshot for windows and mac * BackgroundImage set Null Snapshot for windows and mac
… 2 (#29557) * [Android] clean up modalnavigationmanager * fix failing tests * Handle animation while poping * subscribe to event before showing dailog * change style's names * apply new styles * set result to tcs once dailog dismiss
…27575) * fixed shell items click issue * fix for shell items click issue * fix for flyoutitem in the overflow menu is not fully intractable * fix for flyoutitem in the overflow menu is not fully intractable * Update Issue6784.cs Removed test case fails on Windows * added new image * added new ci image
…ly - fix (#29561) * [Android] The number of SearchHandler toolbar item increases abnormally - fix * Added a UI test * Create NumberOfToolbarItemsShouldNotIncrease.png
…ge's Source to Local File Paths (#28405) * add extra condition * use _sourceCancellation
* Added the CarouselView FeatureMatrix to the hostapp * added test cases * added test cases * updated changes * updated the test cases * modified changes * added issue link * updated layout * updated changes * updated test cases * Changes updated * changes updated * Fix Formatting * Changes updated --------- Co-authored-by: nivetha-nagalingam <nivetha.nagalingam@syncfusion.com> Co-authored-by: LogishaSelvarajSF4525 <logisha.selvaraj@syncfusion.com>
…29604) * Added test cases to ensure menuflyoutitem commands * code optimization * Update src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue20685.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…o the Bottom Tab Icon (#29317) * Fixed the FontImageSource Icon color issues on the BottomNavigationView Tabs * Committed the test sample and case * Added comment over the fix * Remove unnecessary space
* Fixed Test case failure in PR 29469 - [2025/05/26] * Fixed Test case failure in PR 29469 - [2025/05/26]
* CollectionView drag changes on Mac * Mac drag changes
github-actions
Bot
force-pushed
the
inflight/candidate
branch
from
3abc4ba to
44c7fad
Compare
mattleibow
approved these changes
May 30, 2025
github-project-automation
Bot
moved this from Ready To Review
to Approved
in MAUI SDK Ongoing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For more information about inflight process check
https://github.com/dotnet/maui/wiki/Inflight-Branch-Process