Conversation
jfversluis
added
platform/ios
p/0
jfversluis
added
area-controls-general
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reinstates version guards for iOS to continue supporting iOS 12.2+ by reverting some removals from a previous change.
- Reintroduces OS version checks in the keyboard auto manager to properly compute status bar height.
- Adds fallback color values in ColorExtensions for devices running pre-iOS13.
- Reinforces iOS lifecycle event handling with additional OS version checks for scene-based APIs.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Core/src/Platform/iOS/KeyboardAutoManagerScroll.cs | Adds conditional logic to select the proper API based on iOS version |
| src/Core/src/Platform/iOS/ColorExtensions.cs | Restores version guards for color properties compatibility |
| src/Core/src/Hosting/LifecycleEvents/AppHostBuilderExtensions.iOS.cs | Reintroduces pre-iOS13 checks in lifecycle events handlers |
PureWeen
approved these changes
Jun 27, 2025
github-project-automation
Bot
moved this from Ready To Review
to Approved
in MAUI SDK Ongoing
Member
|
/backport to release/9.0.1xx-sr8 |
Contributor
|
Started backporting to release/9.0.1xx-sr8: https://github.com/dotnet/maui/actions/runs/15933415027 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Effectively reverts (part of) #26751. In that PR some checks were removed to see if the app was running iOS 13+ and make decisions on which API to use. For .NET 9 we still support iOS 12.2+ and by just using APIs that are only available on iOS 13+ we now suddenly broke some things.
This PR adds that back so we can still keep supporting iOS 12.2+ for a little while longer.
Issues Fixed
Fixes #30266