[automated] Merge branch 'main' => 'net11.0'

[github-actions]

I detected changes in the main branch which have not been merged yet to net11.0. I'm a robot and am configured to help you automatically keep net11.0 up to date, so I've opened this PR.

This PR merges commits made on main by the following committers:

• mattleibow
• StephaneDelcroix
• rmarinho
• pictos
• PureWeen

Instructions for merging from UI

This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.

If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.

Instructions for merging via command line

Run these commands to merge this pull request from the command line.

git fetch
git checkout main
git pull --ff-only
git checkout net11.0
git pull --ff-only
git merge --no-ff main

# If there are merge conflicts, resolve them and then run git merge --continue to complete the merge
# Pushing the changes to the PR branch will re-trigger PR validation.
git push https://github.com/dotnet/maui HEAD:merge/main-to-net11.0

or if you are using SSH

git push git@github.com:dotnet/maui HEAD:merge/main-to-net11.0

After PR checks are complete push the branch

git push

Instructions for resolving conflicts

⚠️ If there are merge conflicts, you will need to resolve them manually before merging. You can do this using GitHub or using the command line.

Instructions for updating this pull request

Contributors to this repo have permission update this pull request by pushing to the branch 'merge/main-to-net11.0'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.
The provided examples assume that the remote is named 'origin'. If you have a different remote name, please replace 'origin' with the name of your remote.

git fetch
git checkout -b merge/main-to-net11.0 origin/net11.0
git pull https://github.com/dotnet/maui merge/main-to-net11.0
(make changes)
git commit -m "Updated PR with my changes"
git push https://github.com/dotnet/maui HEAD:merge/main-to-net11.0

or if you are using SSH

git fetch
git checkout -b merge/main-to-net11.0 origin/net11.0
git pull git@github.com:dotnet/maui merge/main-to-net11.0
(make changes)
git commit -m "Updated PR with my changes"
git push git@github.com:dotnet/maui HEAD:merge/main-to-net11.0

Contact .NET Core Engineering (dotnet/dnceng) if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/main/.github/workflows/scripts/inter-branch-merge.ps1.

[github-actions]

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://github.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 34789

Or

• Run remotely in PowerShell:

iex "& { $(irm https://github.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 34789"

[github-actions]

🧪 PR Test Evaluation

Overall Verdict: ⚠️ Tests need improvement

This automated merge PR bundles several independent fixes from main. Tests cover the key areas well, but the cross-platform FlyoutPage.cs fix has only an Android-scoped memory test, and the AI device tests carry inherent flakiness risk due to non-deterministic LLM responses.

👍 / 👎 — Was this evaluation helpful? React to let us know!

📊 Expand Full Evaluation

PR Test Evaluation Report

PR: #34789 — [automated] Merge branch 'main' => 'net11.0'
Test files evaluated: 7
Fix files: 51 (logical groups: AI streaming, SourceGen, FlyoutPage/Android navigation)

---

Overall Verdict

⚠️ Tests need improvement

The FlyoutPage.cs fix (handler disconnection on detail change) is cross-platform but is only tested by an Android-scoped memory test. iOS/MacCatalyst coverage is absent despite PhoneFlyoutPageRenderer being registered in SetupBuilder. Additionally, two AI device tests assert against live LLM output, introducing non-determinism risk.

---

1. Fix Coverage — ✅

All three logical fix areas have accompanying tests:

• FlyoutPage detail navigation leak (FlyoutPage.cs, FlyoutViewHandler.Android.cs, NavigationViewFragment.cs) → MemoryTests.FlyoutPageDetailNavigationDoesNotLeak iterates 4 detail replacements and verifies previous pages are GC'd. Test would fail if the handler disconnect fix were reverted. ✅
• SourceGen converter resolution (CSharpExpressionHelpers.cs, KnownMarkups.cs, SetPropertyHelpers.cs) → Maui34713 verifies converters defined in page vs. application resources produce the correct compile-time or runtime resolution. ✅
• SourceGen special chars in x:Key (SetPropertyHelpers.cs) → Maui34726 tests " and \ in resource keys. ✅
• StreamingResponseHandler passthrough mode (StreamingResponseHandler.cs) → 7 unit tests + 2 device tests. ✅

2. Edge Cases & Gaps — ⚠️

Covered:

• FlyoutPage: 4 repeated detail replacements, weak references for all intermediate pages
• FlyoutPage: IsPresented = false after each swap
• Maui34726: Both " and \ special characters, plus a baseline SimpleKey
• Maui34713: Converter in page resources vs. application resources
• StreamingResponseHandler: null input, empty string, duplicate content, passthrough vs. chunker modes

Missing:

• iOS/MacCatalyst memory test — FlyoutPage.cs change fires SendAppearing/SendDisappearing on all platforms, not just Android. The PhoneFlyoutPageRenderer registration was added to SetupBuilder, but there is no corresponding #if IOS || MACCATALYST memory test variant.
• FlyoutPage navigation events — The fix also sends NavigatedFrom/NavigatedTo events; no test verifies these events fire correctly in sequence (e.g., NavigatedFrom on old detail, NavigatedTo on new detail).
• IsPresented = true after swap — Memory test only exercises IsPresented = false; the flyout-open path is untested.

3. Test Type Appropriateness — ✅

Fix Area	Test Type	Verdict
FlyoutPage memory leak (Android)	Device test	✅ Appropriate — needs platform rendering context
FlyoutPage memory leak (iOS)	Missing	⚠️ Device test needed
SourceGen special chars / converter resolution	XAML unit test (SourceGen path)	✅ Appropriate — compile-time behavior
StreamingResponseHandler passthrough	Unit test	✅ Most preferred type for pure logic
AI streaming device behavior	Device test	✅ Appropriate for platform-specific streaming clients

4. Convention Compliance — ⚠️

Script-flagged issues (false positives):

• Maui34713.xaml and Maui34726.xaml flagged as not matching MauiXXXXX — the regex appears to be over-strict; both names follow the 5-digit convention correctly.

Real observations:

• Maui34713.xaml.cs uses xUnit [Fact] within a [Collection("Issue")] class rather than the NUnit [Test] + [Values] XamlInflator pattern described in XAML unit test guidelines. This is intentional — the test exercises SourceGen specifically via CreateMauiCompilation() and doesn't require the XamlInflator parameter. ✅ Acceptable given the scope.
• Maui34726.xaml.cs uses [Theory] + [XamlInflatorData] correctly for the multi-inflator scenario. ✅
• MemoryTests correctly wraps the test in #if ANDROID since it is Android-specific. ✅
• Unit test Passthrough.cs uses [Fact] (xUnit); 7 test methods — all convention compliant. ✅

5. Flakiness Risk — ⚠️ Medium

Risk Factor	Location	Severity
Non-deterministic LLM output	GetStreamingResponseAsync_ConcatenatedTextMatchesNonStreaming compares streaming concatenated text to a separate non-streaming call — both LLM invocations can produce different text	⚠️ Medium
Weak assertion on streaming count	Assert.True(textUpdates.Count >= 1, ...) — a single-chunk response is always valid regardless of chunking behavior	⚠️ Low
Memory tests with WaitForGC	Standard pattern in the repo; GC timing can occasionally be slow in CI, but WaitForGC helper is designed for this	✅ Acceptable

Recommendation: Consider whether GetStreamingResponseAsync_ConcatenatedTextMatchesNonStreaming in device tests needs two separate LLM calls. If the goal is only to verify the streaming text is non-empty and plausible, a single streaming call with a non-empty assertion would be less fragile.

6. Duplicate Coverage — ✅ No duplicates

Existing FlyoutPage tests (FlyoutPageUnitTests.cs, Issue test files) cover different scenarios (navigation, layout behavior) rather than memory/lifecycle. No overlap with the new memory test.

7. Platform Scope — ⚠️

Fix File	Platforms Affected	Test Coverage
FlyoutViewHandler.Android.cs	Android	✅ Android memory test
NavigationViewFragment.cs	Android	✅ (indirectly via memory test)
FlyoutPage.cs	All platforms	⚠️ Android only
CSharpExpressionHelpers.cs	All platforms (SourceGen)	✅ SourceGen XAML tests
StreamingResponseHandler.cs	All platforms	✅ Unit tests are cross-platform

Gap: FlyoutPage.cs logic runs on iOS/MacCatalyst; a memory test for those platforms would increase confidence.

8. Assertion Quality — ✅

• Memory test uses WaitForGC with weak references to all intermediate pages — specific and meaningful. ✅
• Maui34726 asserts exact resource keys including special characters — specific. ✅
• StreamingResponseHandler unit tests assert exact text of each update, count of updates, and role — specific. ✅
• AI device test GetStreamingResponseAsync_DeliversMultipleIncrementalUpdates asserts Count >= 1 — ⚠️ minimal but acceptable for LLM integration.

9. Fix-Test Alignment — ✅

• FlyoutPage.cs fix → MemoryTests.FlyoutPageDetailNavigationDoesNotLeak — exercises exactly the code path that was broken (replacing Detail). ✅
• FlyoutViewHandler.Android.cs fix → same memory test (Android path). ✅
• SourceGen changes → XAML tests for the corresponding issues. ✅
• StreamingResponseHandler.cs → unit tests verify passthrough semantics exactly. ✅

---

Recommendations

1. Add iOS/MacCatalyst memory test for FlyoutPage — A #if IOS || MACCATALYST variant of FlyoutPageDetailNavigationDoesNotLeak would cover the cross-platform code path in FlyoutPage.cs that fires SendAppearing/SendDisappearing.
2. Simplify AI device test assertions — GetStreamingResponseAsync_ConcatenatedTextMatchesNonStreaming makes two separate LLM calls; consider reducing to one streaming call + assertion that the text is non-empty to avoid non-deterministic comparison failures.
3. Add navigation event assertion — A small unit test verifying NavigatedFrom/NavigatedTo events fire in the correct order when FlyoutPage.Detail is replaced would complete the behavioral coverage for FlyoutPage.cs.

Warning

⚠️ Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• dc.services.visualstudio.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "dc.services.visualstudio.com"

See Network Configuration for more information.

Note

🔒 Integrity filtering filtered 1 item

Integrity filtering activated and filtered the following item during workflow execution.
This happens when a tool call accesses a resource that does not meet the required integrity or secrecy level of the workflow.

• pr:[automated] Merge branch 'main' => 'net11.0' #34789 (pull_request_read: Resource 'pr:[automated] Merge branch 'main' => 'net11.0' #34789' has lower integrity than agent requires. Agent would need to drop integrity tags [unapproved:all approved:all] to trust this resource.)

🧪 Test evaluation by Evaluate PR Tests

[PureWeen]

/azp run maui-pr-uitests, maui-pr-devicetests

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[PureWeen]

/azp run maui-pr-uitests, maui-pr-devicetests

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[PureWeen]

/azp run maui-pr-uitests, maui-pr-devicetests

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).