Skip to content

[browser][WBT] Remove MT signalR tests#118323

Merged
ilonatommy merged 2 commits intodotnet:mainfrom
ilonatommy:enable-106807
Aug 4, 2025
Merged

[browser][WBT] Remove MT signalR tests#118323
ilonatommy merged 2 commits intodotnet:mainfrom
ilonatommy:enable-106807

Conversation

@ilonatommy
Copy link
Copy Markdown
Member

@ilonatommy ilonatommy commented Aug 4, 2025

Fixes #106807, fixes #107931.

They can be added once MT is fully operational.

@ilonatommy ilonatommy requested a review from pavelsavara August 4, 2025 06:31
@ilonatommy ilonatommy self-assigned this Aug 4, 2025
Copilot AI review requested due to automatic review settings August 4, 2025 06:31
@ilonatommy ilonatommy requested a review from maraf as a code owner August 4, 2025 06:31
@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-VM-threading-mono labels Aug 4, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes an ActiveIssue attribute that was blocking SignalR client tests in the WebAssembly Build Tests (WBT), allowing these tests to run again after they were previously disabled due to issue #106807.

  • Removes the [ActiveIssue] attribute that was preventing SignalR WBT tests from running
  • Re-enables SignalR client tests for both Debug and Release configurations with LongPolling transport
Comments suppressed due to low confidence (1)

@ilonatommy
Copy link
Copy Markdown
Member Author

ilonatommy commented Aug 4, 2025

This requires some updates after refactoring.

    Wasm.Build.Tests.AspNetCore.SignalRClientTests.SignalRPassMessageWasmBrowser(config: Debug, transport: "LongPolling") [STARTING]
    Wasm.Build.Tests.AspNetCore.SignalRClientTests.SignalRPassMessageWasmBrowser(config: Debug, transport: "LongPolling") [FAIL]
      System.Exception : /root/helix/work/workitem/e/wbt artifacts/SignalRClientTests_Debug_False_hgzgqfdd_rnz_鿀蜒枛遫䡫煉/AspNetCoreServer/WasmBasicTestApp.csproj does not exist
      Stack Trace:
        /_/src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs(273,0): at Wasm.Build.Tests.BuildTestBase.AddItemsPropertiesToProject(String projectFile, String extraProperties, String extraItems, String insertAtEnd)
        /_/src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTestsBase.cs(128,0): at Wasm.Build.Tests.WasmTemplateTestsBase.UpdateProjectFile(String projectFilePath, Boolean runAnalyzers, String extraProperties, String extraItems, String insertAtEnd)
        /_/src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTestsBase.cs(119,0): at Wasm.Build.Tests.WasmTemplateTestsBase.CopyTestAsset(Configuration config, Boolean aot, TestAsset asset, String idPrefix, Nullable`1 appendUnicodeToPath, Boolean runAnalyzers, String extraProperties, String extraItems, String insertAtEnd)
        /_/src/mono/wasm/Wasm.Build.Tests/SignalRTestsBase.cs(26,0): at Wasm.Build.Tests.SignalRTestsBase.SignalRPassMessage(String staticWebAssetBasePath, Configuration config, String transport)
        /_/src/mono/wasm/Wasm.Build.Tests/AspNetCore/SignalRClientTests.cs(26,0): at Wasm.Build.Tests.AspNetCore.SignalRClientTests.SignalRPassMessageWasmBrowser(Configuration config, String transport)
        --- End of stack trace from previous location ---
``

@ilonatommy ilonatommy marked this pull request as draft August 4, 2025 08:44
@ilonatommy ilonatommy changed the title [browser][WBT] SignalR WBT are bumped to net10 [browser][WBT] Remove MT signalR tests Aug 4, 2025
@ilonatommy ilonatommy marked this pull request as ready for review August 4, 2025 11:02
@ilonatommy ilonatommy enabled auto-merge (squash) August 4, 2025 12:34
@ilonatommy ilonatommy merged commit 8083ecc into dotnet:main Aug 4, 2025
28 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-VM-threading-mono

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Long running test timeout - Wasm.Build.Tests.AspNetCore.SignalRClientTests.SignalRPassMessageWasmBrowser [browser][WBT] Bump SignalR WBT to net10

3 participants