Skip to content

Re-enable C++/CLI, SourceLink C++, and compilation context tests now that VS 2026 Helix images include VCTools #53820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcpopMSFT merged 3 commits into from
Apr 23, 2026
Merged

Re-enable C++/CLI, SourceLink C++, and compilation context tests now that VS 2026 Helix images include VCTools #53820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a005e04
Re-enable C++/CLI and SourceLink Cpp tests (revert issue #53789 skips)
Copilot Apr 10, 2026
f2d612b
Re-enable net46 InlineData test case (revert issue #53796 skip)
Copilot Apr 15, 2026
fe24fac
Merge branch 'main' into copilot/revert-changes-testing-vctool
MichaelSimons Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildACppCliProject.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public GivenThatWeWantToBuildACppCliProject(ITestOutputHelper log) : base(log)
{
}

[FullMSBuildOnlyFact(Skip = "https://github.com/dotnet/sdk/issues/53789")]
[FullMSBuildOnlyFact]
public void It_builds_and_runs()
{
var testAsset = TestAssetsManager
Expand Down Expand Up @@ -49,7 +49,7 @@ public void It_builds_and_runs()
.HaveStdOutContaining("Hello, World!");
}

[FullMSBuildOnlyFact(Skip = "https://github.com/dotnet/sdk/issues/53789")]
[FullMSBuildOnlyFact]
public void It_builds_and_runs_with_package_reference()
{
var targetFramework = ToolsetInfo.CurrentTargetFramework + "-windows";
Expand Down Expand Up @@ -84,7 +84,7 @@ public void It_builds_and_runs_with_package_reference()
}
}

[FullMSBuildOnlyFact(Skip = "https://github.com/dotnet/sdk/issues/53789")]
[FullMSBuildOnlyFact]
public void Given_no_restore_It_builds_cpp_project()
{
var testAsset = TestAssetsManager
Expand All @@ -98,7 +98,7 @@ public void Given_no_restore_It_builds_cpp_project()
.Pass();
}

[FullMSBuildOnlyFact(Skip = "https://github.com/dotnet/sdk/issues/53789")]
[FullMSBuildOnlyFact]
public void Given_Wpf_framework_reference_It_builds_cpp_project()
{
var testAsset = TestAssetsManager
Expand All @@ -111,7 +111,7 @@ public void Given_Wpf_framework_reference_It_builds_cpp_project()
.Pass();
}

[FullMSBuildOnlyFact(Skip = "https://github.com/dotnet/sdk/issues/53789")]
[FullMSBuildOnlyFact]
public void It_fails_with_error_message_on_EnableComHosting()
{
var testAsset = TestAssetsManager
Expand Down Expand Up @@ -139,7 +139,7 @@ public void It_fails_with_error_message_on_EnableComHosting()
.HaveStdOutContaining(Strings.NoSupportCppEnableComHosting);
}

[FullMSBuildOnlyFact(Skip = "https://github.com/dotnet/sdk/issues/53789")]
[FullMSBuildOnlyFact]
public void It_fails_with_error_message_on_fullframework()
{
var testAsset = TestAssetsManager
Expand All @@ -156,7 +156,7 @@ public void It_fails_with_error_message_on_fullframework()
.HaveStdOutContaining(Strings.NETFrameworkWithoutUsingNETSdkDefaults);
}

[FullMSBuildOnlyFact(Skip = "https://github.com/dotnet/sdk/issues/53789")]
[FullMSBuildOnlyFact]
public void It_fails_with_error_message_on_tfm_lower_than_3_1()
{
var testAsset = TestAssetsManager
Expand All @@ -173,7 +173,7 @@ public void It_fails_with_error_message_on_tfm_lower_than_3_1()
.HaveStdOutContaining(Strings.CppRequiresTFMVersion31);
}

[FullMSBuildOnlyFact(Skip = "https://github.com/dotnet/sdk/issues/53789")]
[FullMSBuildOnlyFact]
public void When_run_with_selfcontained_It_fails_with_error_message()
{
var testAsset = TestAssetsManager
Expand Down
6 changes: 3 additions & 3 deletions test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildACppCliProjectWithTransitiveDeps.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public GivenThatWeWantToBuildACppCliProjectWithTransitiveDeps(ITestOutputHelper

private readonly Lazy<TestAsset> _buildAsset;

[FullMSBuildOnlyFact(Skip = "https://github.com/dotnet/sdk/issues/53789")]
[FullMSBuildOnlyFact]
public void It_can_generate_correct_depsJson_file()
{
TestAsset testAsset = _buildAsset.Value;
Expand All @@ -23,7 +23,7 @@ public void It_can_generate_correct_depsJson_file()
depsJsonContent.Should().Contain("NETCoreCppCliTestC.dll", "should contain transitive reference");
}

[FullMSBuildOnlyFact(Skip = "https://github.com/dotnet/sdk/issues/53789")]
[FullMSBuildOnlyFact]
public void It_can_generate_all_runtimeconfig_files_to_output_folder()
{
TestAsset testAsset = _buildAsset.Value;
Expand All @@ -35,7 +35,7 @@ public void It_can_generate_all_runtimeconfig_files_to_output_folder()
});
}

[FullMSBuildOnlyFact(Skip = "https://github.com/dotnet/sdk/issues/53789")]
[FullMSBuildOnlyFact]
public void It_can_generate_all_depsjson_files_to_output_folder()
{
TestAsset testAsset = _buildAsset.Value;
Expand Down
2 changes: 1 addition & 1 deletion test/Microsoft.NET.Build.Tests/SourceLinkTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ public void SuppressImplicitGitSourceLink_ExplicitPackage(bool multitarget)
}
}

[FullMSBuildOnlyFact(Skip = "https://github.com/dotnet/sdk/issues/53789")]
[FullMSBuildOnlyFact]
public void Cpp()
{
var testAsset = TestAssetsManager
Expand Down
2 changes: 1 addition & 1 deletion test/Microsoft.NET.Pack.Tests/GivenThatWeWantToPackACppCliProject.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public GivenThatWeWantToPackACppCliProject(ITestOutputHelper log) : base(log)
{
}

[FullMSBuildOnlyFact(Skip = "https://github.com/dotnet/sdk/issues/53789")]
[FullMSBuildOnlyFact]
public void It_cannot_pack_the_cppcliproject()
{
var testAsset = TestAssetsManager
Expand Down
3 changes: 1 addition & 2 deletions test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPreserveCompilationContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@ public GivenThatWeWantToPreserveCompilationContext(ITestOutputHelper log) : base
}

[Theory]
// Skip = "https://github.com/dotnet/sdk/issues/53796"
//[InlineData("net46", "netstandard1.3", false)]
[InlineData("net46", "netstandard1.3", false)]
[InlineData("netcoreapp2.0", "netstandard2.0", false)]
[InlineData("netcoreapp2.0", "netstandard2.0", true)]
[InlineData("netcoreapp3.0", "netstandard2.0", false)]
Expand Down
2 changes: 1 addition & 1 deletion test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishACppCliProject.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public GivenThatWeWantToPublishACppCliProject(ITestOutputHelper log) : base(log)
{
}

[FullMSBuildOnlyFact(Skip = "https://github.com/dotnet/sdk/issues/53789")]
[FullMSBuildOnlyFact]
public void When_referenced_by_csharp_project_it_publishes_and_runs()
{
var testAsset = TestAssetsManager
Expand Down
Loading