Skip to content

Re-run failed run-file tests with verbose logging #53883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jjonescz wants to merge 1 commit into from
Closed

Re-run failed run-file tests with verbose logging #53883

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions test/dotnet.Tests/CommandTests/Run/RunFileTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.Diagnostics;
using Microsoft.Build.Framework;
using Microsoft.Build.Logging.StructuredLogger;
using Microsoft.DotNet.Cli.Commands;
Expand Down Expand Up @@ -185,9 +186,17 @@ private protected void Build(
command = customizeCommand(command);
}

command.Execute()
.Should().Pass()
.And.HaveStdOut(prefix + expectedOutput);
var result = command.Execute();

var fullExpectedOutput = prefix + expectedOutput;
if (result.ExitCode != 0 || result.StdOut != fullExpectedOutput)
{
// Re-run with verbose logging for easier debugging of test failures.
command.WithEnvironmentVariable(CommandLoggingContext.Variables.Verbose, bool.TrueString).Execute();

result.Should().Pass().And.HaveStdOut(fullExpectedOutput);
throw new UnreachableException();
}

var binlogs = new DirectoryInfo(workDir ?? testInstance.Path)
.EnumerateFiles("*.binlog", SearchOption.TopDirectoryOnly);
Expand Down
Loading