Skip to content

Migrate CollectSDKReferencesDesignTime to IMultiThreadableTask #53953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
SimaTian wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Migrate CollectSDKReferencesDesignTime to IMultiThreadableTask #53953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b0d631
Migrate CollectSDKReferencesDesignTime to IMultiThreadableTask
SimaTian Apr 17, 2026
ad011e7
Address CollectSDKReferencesDesignTime feedback
SimaTian Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions src/Tasks/Microsoft.NET.Build.Tasks/CollectSDKReferencesDesignTime.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,19 @@ namespace Microsoft.NET.Build.Tasks
/// Tracking issue https://github.com/dotnet/roslyn-project-system/issues/587
/// </summary>
[MSBuildMultiThreadableTask]
public class CollectSDKReferencesDesignTime : TaskBase
public class CollectSDKReferencesDesignTime : TaskBase, IMultiThreadableTask
{
#if NETFRAMEWORK
private TaskEnvironment _taskEnvironment;
public TaskEnvironment TaskEnvironment
{
get => _taskEnvironment ??= TaskEnvironmentDefaults.Create();
set => _taskEnvironment = value;
Comment on lines +21 to +26
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On NETFRAMEWORK, the lazy default TaskEnvironment creates a ProcessTaskEnvironmentDriver(Directory.GetCurrentDirectory()), which enumerates process environment variables and captures the current working directory. That adds side effects/overhead (and contradicts the PR’s stated “zero env-var reads”) even though this task is otherwise pure in-memory. Consider making TaskEnvironment a simple settable property (letting MSBuild supply it) or using a lightweight in-memory driver that doesn’t snapshot process environment/CWD when a fallback is needed.

Copilot uses AI. Check for mistakes.
}
#else
public TaskEnvironment TaskEnvironment { get; set; }
#endif

[Required]
public ITaskItem[] SdkReferences { get; set; }

Expand All @@ -30,14 +41,12 @@ public class CollectSDKReferencesDesignTime : TaskBase
[Output]
public ITaskItem[] SDKReferencesDesignTime { get; set; }

private HashSet<string> ImplicitPackageReferences { get; set; }

protected override void ExecuteCore()
{
ImplicitPackageReferences = GetImplicitPackageReferences(DefaultImplicitPackages);
var implicitPackageReferences = GetImplicitPackageReferences(DefaultImplicitPackages);

var sdkDesignTimeList = new List<ITaskItem>(SdkReferences);
sdkDesignTimeList.AddRange(GetImplicitPackageReferences());
sdkDesignTimeList.AddRange(GetImplicitPackageReferences(implicitPackageReferences));

SDKReferencesDesignTime = sdkDesignTimeList.ToArray();
}
Expand All @@ -64,7 +73,7 @@ internal static HashSet<string> GetImplicitPackageReferences(string defaultImpli
return implicitPackageReferences;
}

private IEnumerable<ITaskItem> GetImplicitPackageReferences()
private IEnumerable<ITaskItem> GetImplicitPackageReferences(HashSet<string> implicitPackageReferences)
{
var implicitPackages = new List<ITaskItem>();
foreach (var packageReference in PackageReferences)
Expand All @@ -73,7 +82,7 @@ private IEnumerable<ITaskItem> GetImplicitPackageReferences()
var isImplicitlyDefinedString = packageReference.GetMetadata(MetadataKeys.IsImplicitlyDefined);
if (string.IsNullOrEmpty(isImplicitlyDefinedString))
{
isImplicitlyDefined = ImplicitPackageReferences.Contains(packageReference.ItemSpec);
isImplicitlyDefined = implicitPackageReferences.Contains(packageReference.ItemSpec);
}
else
{
Expand Down
Loading
Loading