Skip to content

Fix BuildWorkloadMsis failure by explicitly packing manifests in graph mode #54030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marcpopMSFT wants to merge 1 commit into from
Closed

Fix BuildWorkloadMsis failure by explicitly packing manifests in graph mode #54030

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/Workloads/VSInsertion/workloads.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,19 @@
UseHardlinksIfPossible="true" />
</Target>

<!-- In graph build mode (.slnx), the Traversal SDK's Pack target in manifest-packages.csproj
is skipped because it has Condition="'$(IsGraphBuild)' != 'true'". The graph scheduler is
supposed to dispatch Pack to the child .Manifest.proj projects via ProjectReferenceTargets,
but the graph builder does not discover them. Explicitly invoke Pack here without IsGraphBuild
so the Traversal SDK's Pack target executes normally. -->
<Target Name="_PackManifestPackages"
BeforeTargets="BuildWorkloadMsis"
Condition="'$(BuildWorkloads)' == 'true' and '$(DotNetBuild)' != 'true' and '$(IsGraphBuild)' == 'true'">
<MSBuild Projects="$(RepoRoot)src\Workloads\Manifests\manifest-packages.csproj"
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MSBuild Projects path is missing the path separator after $(RepoRoot). In this file the existing ProjectReference uses $(RepoRoot)\src\..., but here it’s $(RepoRoot)src\..., which will produce an invalid path when RepoRoot doesn’t already end with a slash.

Suggested change
<MSBuild Projects="$(RepoRoot)src\Workloads\Manifests\manifest-packages.csproj"
<MSBuild Projects="$(RepoRoot)\src\Workloads\Manifests\manifest-packages.csproj"

Copilot uses AI. Check for mistakes.
Targets="Pack"
RemoveProperties="IsGraphBuild" />
</Target>

<Target Name="BuildWorkloadMsis"
Condition="'$(BuildWorkloads)' == 'true' and '$(DownloadWorkloadMsis)' != 'true'">
<ItemGroup>
Expand Down
Loading