Set up dependOn task only if project is affected#240
Set up dependOn task only if project is affected#240joshafeinberg merged 4 commits intodropbox:mainfrom
Conversation
|
|
1 similar comment
|
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #240 +/- ##
============================================
- Coverage 53.14% 53.04% -0.10%
Complexity 73 73
============================================
Files 16 16
Lines 557 558 +1
Branches 102 102
============================================
Hits 296 296
- Misses 234 235 +1
Partials 27 27 ☔ View full report in Codecov by Sentry. |
Fixes #223
This change will reduce the amount of task that needs to be configured.
The idea is this. When a task doesn't have to run, and if we know it. There is no need to depend on that task and skip it later. The plugin can only depend on the task that should run.
I couldnt now how to test it but I compared change in our project.
Before the change of this pr, tasks that belong to modules that has no change or not affected also created but skipped.
After this change, tasks from unaffected modules are not created.
Any pre task that depends on actual task we are calling also being executed in original implementation.
After the change, you can see that only affected modules tasks are created and called.
(Change is in in-app-notification module)