Support usage in projects using Gradle 8.10 by avoiding using Project.equals

[anthonycr]

I can't find anything in the Gradle 8.10 release notes or issue tracker, but we've found that the affected module detector (both versions 0.3.1 and 0.3.0) stops working on Gradle 8.10.

Using 0.3.1 we are seeing that no tasks will run and AMD always sees that no modules have changed. I downgraded our integration to 0.3.0 to obtain logs and work around #205, and saw that AMD is correctly identifying all the changed modules, but when it goes to identify whether those changed modules should be included in the build, it always returns false for every module.

I suspected that the cause was the use of Set<Project> and subsequent usage of Set.contains(Project), which would rely on the Project intrinsic equals implementation. Neither Project nor DefaultProject implement equals, and it seems like separate Project instances are getting created now in Gradle 8.10 (I'm not sure why). As a result, the default equals implementation is returning false when checking equivalent projects. I added this repository as an included build and updated the usage of Set<Project> to Map<String, Project> where String was the project path, and AMD worked as expected.

This MR updates the usage of Set<Project> to Map<ProjectPath, Project> where ProjectPath is a value class that wraps the path. It updates the tests to expect Map<ProjectPath, Project> instead of Set<Project>, but it does not update the Gradle version. Note: I didn't update the Gradle version so that we don't potentially lock out consumers on older Gradle versions from using AMD.

I can work on a repro project containing both Gradle 8.9 and 8.10, if needed, to demonstrate the issue.

[CLAassistant]

All committers have signed the CLA.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[joshafeinberg]

Thanks for this, first thing I've found is the sample app's buildSrc needs a bit of an update in /sample/buildSrc/src/main/kotlin/com/dropbox/sample/tasks/AffectedTasksPlugin.kt. it references the map so it can't figure out the lambda

If you could push up a fix for that I can run the CI and get some tests going

[anthonycr]

Thanks for this, first thing I've found is the sample app's buildSrc needs a bit of an update in /sample/buildSrc/src/main/kotlin/com/dropbox/sample/tasks/AffectedTasksPlugin.kt. it references the map so it can't figure out the lambda

If you could push up a fix for that I can run the CI and get some tests going

Oops! I didn't notice that the sample was being configured separately from the plugin 😅 Updated the sample app to compile.