Experimental Windows support#77
Closed
mezpahlan wants to merge 42 commits intodropbox:mainfrom
Closed
Conversation
|
|
JCenter is dead.
The names were incorrect.
This is so that we can more easily share versions between the main project and the sample project to avoid a mismatch.
Preparing for Kotlin DSL.
Circular dependency issue since you need to have built and published the plugin to mavenLocal first before you can meaningfully use anything in the sample directory :(. For the time being we will do this by hand.
Do not assume Unix like path separators and illegal characters.
TestRule for those of us that have not set the ANDROID_SDK_ROOT environment variable.
No point continuing.
These are forced to Unix-like characters but Gradle interprets them in the correct OS format. This only causes problems on Windows machines but needs proper handling.
Remove unused / not referenced projects. Fix p5 dependency.
It is safe to use the forward slash "/" character when working with Gradle or Java File as they both understand how to handle this on all platforms. The Git client is the one that causes us problems.
This distinguishes what the file tree relationship is as opposed to the dependency relationship. It should also make it easier to express more complex set ups.
This file can grow extremely quickly. When that happens, trying to read it becomes tricky. We should probably put this behind a configuration in the future.
Protects against users specifying the wrong path separator.
mezpahlan
force-pushed
the
experimental-windows-support
branch
from
d33c739 to
1b51713
Compare
Centralises an important but shared function.
Contributor
Author
|
Apologies my company won't allow me to sign the CLA and as I have done the work during company time I don't feel correct signing the agreement myself. The commits are there if you want them but I will close this PR. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to address #37 by adding experimental Windows support (I say experimental because really what we should be doing is using an abstract file system like the one from Okio and write proper tests for each known target platform - Linux, Mac, Windows. However to begin with I just wanted to get something that worked on Windows.)
The main issue I noticed was that
GitClientImplseems to always return Unix-like line endings and path separators -"\n"/"/". However Gradle returns the appropriate constants for the target operating system. On Windows this is"\r\n"/"\". The AffectedModuleDetector (at its heart) compares the output from Git with the output from Gradle and compares the two to work out changes. Therefore each output needs to be in the same format.The main changes are:
buildSrcdirectory for both the plugin module and the sample module.":"on Windows 😢 ).