Support pnpm package manager

[vjpr]

https://github.com/pnpm/pnpm

[ds300]

Hi! Looks like patch-package wouldn't work with pnpm, unfortunately.

pnpm uses hard links and symlinks to save one version of a module only ever once on a disk. When using npm or Yarn for example, if you have 100 projects using the same version of lodash, you will have 100 copies of lodash on disk. With pnpm, lodash will be saved in a single place on the disk and a hard link will put it into the node_modules where it should be installed.

Meanwhile, patch-package requires files to be fully copied in to node_modules, not just linked.

[vjpr]

Hmm, I did not think of that.

@zkochan How could this package be used for pnpm? Can a hook patch a module?

[zkochan]

@vjpr with a pnpm hook you can install a package from a local tarball instead of the registry. The local tarball can contain the modified package. Or you could publish the fixed package with a different name, or you could install if from your fork.

[ds300]

Thanks @zkochan

The other issue is that patch-package's core patch generation UX flow wouldn't work. That flow is:

1. Edit files inside your node_modules folder
2. run patch-package to generate a patch file based on your edits

With pnpm, editing files inside your node_modules folder will affect all other pnpm projects on your machine, which is probably not what you want.

The patch application process could be automated using the hooks, but I can't think of a way to make patch generation easy. Any ideas?

[vjpr]

With pnpm, editing files inside your node_modules folder will affect all other pnpm projects on your machine, which is probably not what you want.

For patch creation, I think this workflow still works. When pnpm install is run, it detects that the global store has changed and will reinstall so there is no problem there. I do it all the time.

For patch application, though currently it would never work. It would need to use the pnpm plugin feature as @zkochan mentioned.

[ds300]

closing this issue due to inactivity

[jtyers]

I'm hitting this today. Use pnpm regularly and now have a pressing need to patch a dependency. Unfortunately creating a patch fails under pnpm with:

$ npx patch-package mname                                                  -INSERT- 
patch-package 6.2.0
• Creating temporary folder
• Installing mname@1.5.0 with npm
• Diffing your files with clean files
{ Error: ENOENT: no such file or directory, scandir '/tmp/tmp-4739623rx72YYljFtx/node_modules/mname'
    at Object.readdirSync (fs.js:790:3)
<snip>
  errno: -2,
  syscall: 'scandir',
  code: 'ENOENT',
  path: '/tmp/tmp-4739623rx72YYljFtx/node_modules/mname' }
<snip>
Error: ENOENT: no such file or directory, scandir '/tmp/tmp-4739623rx72YYljFtx/node_modules/mname'
    at Object.readdirSync (fs.js:790:3)

Digging into the way patch-package does its diffing, I suspect copying a directory which is itself a symlink is causing the barf.

It'd be great to support pnpm - in my case, I'm happy to have a patch to a dependency affect all the versions of that package installed on the system.

Aside/as well as pnpm hooks, the https://pnpm.js.org/en/workspaces support might be a way of getting what we want, as it looks like packages are stored per-workspace.

[lenovouser]

I am experiencing the same problem, can this be fixed on patch-package's side or does this need to be done in pnpm?

[diachedelic]

It seems to apply existing patches ok using pnpm@5.2.6, patch-package@6.2.2 and node@12.16.1 - not sure about generating them, but that can be done manually if necessary.

[DrSensor]

same here, pnpx patch-package <pkg> not working

patch-package 6.2.2

**ERROR** No package-lock.json, npm-shrinkwrap.json, or yarn.lock file.

You must use either npm@>=5, yarn, or npm-shrinkwrap to manage this project's
dependencies.

related PR #73 #252