Skip to content

Create placeholder instance models#3821

Open
r4victor wants to merge 15 commits intomasterfrom
issue_3665_placeholder_instance_models
Open

Create placeholder instance models#3821
r4victor wants to merge 15 commits intomasterfrom
issue_3665_placeholder_instance_models

Conversation

@r4victor
Copy link
Copy Markdown
Collaborator

@r4victor r4victor commented Apr 23, 2026

Closes #3665
Fixes #3663

  • Refactor JobSubmittedPipeline flow to create a "placeholder" InstanceModel before provisioning the instance in the cloud. This helps with proper fleets' nodes.max accounting and instance_num reservation, and prepares for proper instance termination in case of stale worker (still TBD).
  • Add InstanceModel.provisioning_job_id to distinguish placeholder instances vs pending instances processed by InstancePipeline.
  • Carefully update all the places to account for placeholder instances where fleet instances are filtered for empty check, placement group selection, master election, etc.
  • Disallow deleting "placeholder" instances to avoid racing with pipelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant