Use static initializer for main pthread struct#23904
Closed
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Closed
Use static initializer for main pthread struct#23904sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
Turns out this is a slight regression in code size because we end up with more data segments that cannot got in .bss. I guess its not worth landing?
Member
|
Hmm, yeah, I guess it moves stuff to data, which then is no longer zeroes... I tend to agree it isn't worth landing, unless there is a benefit I am missing. |
Collaborator
Author
|
No, I just wanted share these slightly surprising results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out this is a slight regression in code size because we end up with more data segments that cannot got in .bss. I guess its not worth landing?