bazel: add additional_libs support to envoy_directory_genrule#44253
Open
jwendell wants to merge 1 commit intoenvoyproxy:mainfrom
Open
bazel: add additional_libs support to envoy_directory_genrule#44253jwendell wants to merge 1 commit intoenvoyproxy:mainfrom
jwendell wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
Add an `additional_libs` attribute to the `envoy_directory_genrule` rule, allowing callers to specify shared libraries that should be included as inputs and made available via LD_LIBRARY_PATH. Signed-off-by: Jonh Wendell <jwendell@redhat.com>
phlax
reviewed
Apr 2, 2026
Member
phlax
left a comment
phlax
left a comment
There was a problem hiding this comment.
are you not going to include the macro?
Member
Author
The macro references openssl in the select(), it doesn't make sense to put it here... if I understand correctly what you're asking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an
additional_libsattribute to theenvoy_directory_genrulerule, allowing callers to specify shared libraries that should be included as inputs and made available via LD_LIBRARY_PATH.