health_checks: support multiple health checks on the same cluster#44255
Draft
ggreenway wants to merge 1 commit intoenvoyproxy:mainfrom
Draft
health_checks: support multiple health checks on the same cluster#44255ggreenway wants to merge 1 commit intoenvoyproxy:mainfrom
ggreenway wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
Fixes envoyproxy#3642 Signed-off-by: Greg Greenway <ggreenway@apple.com>
Member
Author
|
@wbpcode this is still a draft, but since you did some work in this area in #16391 a long time ago, I wanted to get your input on the overall design. This isn't ready for a close code review yet. This design tries to change as little as possible when only a single health check is configured, because I think that will always be the majority use case, and I don't want to introduce bugs for the existing code. Can you look at my changes to the envoy interfaces for this, and how I used a proxy object |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3642
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]