Skip to content

health_checks: support multiple health checks on the same cluster#44255

Draft
ggreenway wants to merge 1 commit intoenvoyproxy:mainfrom
ggreenway:multiple-hc
Draft

health_checks: support multiple health checks on the same cluster#44255
ggreenway wants to merge 1 commit intoenvoyproxy:mainfrom
ggreenway:multiple-hc

Conversation

@ggreenway
Copy link
Copy Markdown
Member

Fixes #3642

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Fixes envoyproxy#3642

Signed-off-by: Greg Greenway <ggreenway@apple.com>
@repokitteh-read-only
Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #44255 was opened by ggreenway.

see: more, trace.

@ggreenway
Copy link
Copy Markdown
Member Author

@wbpcode this is still a draft, but since you did some work in this area in #16391 a long time ago, I wanted to get your input on the overall design. This isn't ready for a close code review yet.

This design tries to change as little as possible when only a single health check is configured, because I think that will always be the majority use case, and I don't want to introduce bugs for the existing code.

Can you look at my changes to the envoy interfaces for this, and how I used a proxy object HealthCheckerGroup, and tell me if you like that design or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[active health checking] Implement multiple health checkers per cluster

2 participants