Skip to content

chore: remove unused code#122

Merged
tac0turtle merged 1 commit intomainfrom
julien/deadcode
Jun 5, 2025
Merged

chore: remove unused code#122
tac0turtle merged 1 commit intomainfrom
julien/deadcode

Conversation

@julienrbrt
Copy link
Copy Markdown
Member

@julienrbrt julienrbrt commented Jun 5, 2025

This code was duplicated here: https://github.com/rollkit/go-execution-abci/blob/183ecbc22ac92e7d6798e0819ed3958dd188509d/pkg/common/convert.go#L80

Summary by CodeRabbit

  • Chores
    • Removed internal utility functions related to blockchain data structure conversions. No changes are visible to end-users.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 5, 2025

Walkthrough

The update marks a test helper function with t.Helper() in a consensus test file, improving error reporting. Additionally, the pkg/rpc/utils.go file is deleted, removing several utility functions responsible for converting Rollkit blockchain data structures into CometBFT (Tendermint) ABCI-compatible formats.

Changes

File(s) Change Summary
pkg/rpc/core/consensus_test.go Added t.Helper() call to the setupTestValidatorsEnv test helper function.
pkg/rpc/utils.go Deleted file containing utility functions for Rollkit-to-CometBFT ABCI data structure conversions.

Suggested reviewers

  • gupadhyaya
  • tac0turtle

Poem

In the warren, helpers now declare,
"I'm here to aid and show I care!"
Old bridges to ABCI, swept away—
The code grows lighter every day.
With every hop, we prune and mend,
Onward, rabbit-friends, to the next bend! 🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (1.64.8)

Error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2
Failed executing command with error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9558f82 and 183ecbc.

📒 Files selected for processing (2)
  • pkg/rpc/core/consensus_test.go (1 hunks)
  • pkg/rpc/utils.go (0 hunks)
💤 Files with no reviewable changes (1)
  • pkg/rpc/utils.go
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: lint / golangci-lint
  • GitHub Check: test / Run Unit Tests
  • GitHub Check: Test with Rollkit Chain
🔇 Additional comments (1)
pkg/rpc/core/consensus_test.go (1)

90-90: Marking test helper properly.

Adding t.Helper() here is correct—it ensures errors within this helper are reported at the caller site, improving test diagnostics.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tac0turtle tac0turtle merged commit db9cdef into main Jun 5, 2025
13 checks passed
@tac0turtle tac0turtle deleted the julien/deadcode branch June 5, 2025 07:47
@coderabbitai coderabbitai Bot mentioned this pull request Jun 11, 2025
chatton pushed a commit that referenced this pull request Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants