types/validation.go
if len(h.Commit.Signatures) != len(h.Validators.Validators) {
return errors.New("number of signatures and keys don't match")This code breaks if you only have 1 signature but multiple validator keys.
We will have multiple sequencers schemes, so ideally, validation should hook into FCR Interface at some point.
Comment by @gupadhyaya :
this has to be handled by the staking module which keeps the set of allowed signers, their public keys, and then also defines the threshold for acceptance and we can simply make a call to the staking module to return boolean. this does not matter right now as we are setting the signer (single) and his public key in the signer header before gossip. so this condition will always hold. we can keep it this way for now?
types/validation.go
This code breaks if you only have 1 signature but multiple validator keys.
We will have multiple sequencers schemes, so ideally, validation should hook into FCR Interface at some point.
Comment by @gupadhyaya :