Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1178 +/- ##
==========================================
- Coverage 56.08% 55.71% -0.38%
==========================================
Files 63 63
Lines 6711 6711
==========================================
- Hits 3764 3739 -25
- Misses 2560 2583 +23
- Partials 387 389 +2 ☔ View full report in Codecov by Sentry. |
|
@MSevey can we inherit from app or node? either we can just do |
I don't think we can inherit another repo's makefile in a clean way. But happy to use the golangci-lint --fix flag 👍 |
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. --> Closes #223 Instead of adding a formatted to the CI, which would introduce a diff that would need to be committed, I extended the `make fmt` command.
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. --> Closes evstack#223 Instead of adding a formatted to the CI, which would introduce a diff that would need to be committed, I extended the `make fmt` command.
Overview
Closes #223
Instead of adding a formatted to the CI, which would introduce a diff that would need to be committed, I extended the
make fmtcommand.