chore(celestia-node-fiber): bump celestia-node to feature/fibre-experimental#3289
Merged
sysrex merged 1 commit intoevstack:julien/fiberfrom Apr 27, 2026
Conversation
…imental Picks up the chained celestia-app bump on celestia-node feature/fibre-experimental, which carries the x/valaddr host:port validation fix (celestia-app PR #7183). Cascading changes required by the bump: - celestia-app v8 → v9 across adapter.go, adapter_test.go, listen.go, testing/network.go, testing/bridge.go (the new celestia-node uses v9, so the consumer must too). - testing/network.go drops the `dns:///` prefix from the in-process validator registration. The new x/valaddr ValidateBasic enforces host:port form, so `dns:///host:port` registrations are now rejected at tx time. gRPC's passthrough resolver dials bare `host:port` directly with no behavioural difference. Verified locally: go vet -tags fibre ./... — clean go test -tags fibre -short -run TestShowcase — pass Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
walldiss
added a commit
to walldiss/ev-node
that referenced
this pull request
Apr 27, 2026
The chain (built from celestia-app feat/fibre-payments via the bumped Dockerfile.app default ref) now enforces strict host:port form on MsgSetFibreProviderInfo.ValidateBasic. Adjusts the docker stack accordingly: - Dockerfile.app default CELESTIA_APP_REF: main → feat/fibre-payments - Dockerfile.bridge default CELESTIA_NODE_REF: feature/fibre → feature/fibre-experimental (which carries the matching app bump) - register-fsps.sh registers plain `127.0.0.1:798X` (was `dns:///...`) - docker_test.go celestia-app v8 → v9 imports (cascades from the julien/fiber bump merged in evstack#3289) bad_host_repro_test.go matrix flips: - host_port → set-host succeeds, Upload succeeds (positive) - http_prefix → set-host fails at ValidateBasic - dns_prefix → set-host fails at ValidateBasic …with assertion against `host must be in host:port form` from the chain's response. Cleanup uses --output json so the success-code check parses reliably; sleep widened to 4s between consecutive set-host calls so the validator account's mempool nonce settles. Verified locally on docker-arm64: TestDockerShowcase PASS 5.20s TestEvNode_FiberDA_Docker PASS 8.00s TestFibreClient_HostRegistrationFormats PASS 80.01s Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps celestia-node from its previous
feature/fibre-tracking commit tofeature/fibre-experimental, which in turn pulls in the celestia-appfeat/fibre-paymentstip with thex/valaddrhost:port validation fix (celestia-app#7183).Cascading changes
The new celestia-node references celestia-app v9, while ev-node's
tools/celestia-node-fiberwas still on v8. Updated all import paths to v9 across:adapter.go,adapter_test.go,listen.gotesting/network.go,testing/bridge.goAlso dropped the
dns:///prefix from the in-process validator registration intesting/network.go. The newx/valaddr.ValidateBasicenforces stricthost:portform —dns:///host:portregistrations are now rejected at tx time. gRPC's default passthrough resolver dials barehost:portdirectly with no behavioural change.Why this matters for consumers
tools/celestia-node-fiber: pick up the validation fix transparently after this bump. No config or registration change required if validators have correctly registered host strings.dns:///host:portregistrations need to be overwritten with plainhost:portafter the chain upgrades.Verification
go vet -tags fibre ./...— cleango test -tags fibre -short -run TestShowcase ./tools/celestia-node-fiber/testing/...— passCloses: https://linear.app/celestia/issue/PROTOCO-1605/ev-node-bump-celestia-node-to-featurefibre-experimental-hostport
🤖 Generated with Claude Code