Skip to content

feat: serialize state with protobuf#424

Merged
tzdybal merged 5 commits intomainfrom
tzdybal/state_serialization
Jun 10, 2022
Merged

feat: serialize state with protobuf#424
tzdybal merged 5 commits intomainfrom
tzdybal/state_serialization

Conversation

@tzdybal
Copy link
Copy Markdown
Contributor

@tzdybal tzdybal commented Jun 2, 2022

  • move State to types package
  • create protobuf definition for State
  • add FromProto and ToProto methods
  • fill validator sets in tests
  • add scripts to fetch proto files from tendermint repo

Resolves #421.

Related to #37.

@tzdybal tzdybal requested a review from jbowen93 June 2, 2022 11:32
@tzdybal tzdybal self-assigned this Jun 2, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 3, 2022

Codecov Report

Merging #424 (9113e69) into main (47f481b) will decrease coverage by 1.61%.
The diff coverage is 41.48%.

@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
- Coverage   56.56%   54.95%   -1.62%     
==========================================
  Files          47       48       +1     
  Lines        7858     8747     +889     
==========================================
+ Hits         4445     4807     +362     
- Misses       2777     3207     +430     
- Partials      636      733      +97     
Impacted Files Coverage Δ
types/state.go 92.10% <ø> (ø)
types/pb/optimint/state.pb.go 38.73% <38.73%> (ø)
block/manager.go 62.38% <57.14%> (ø)
types/serialization.go 69.23% <65.00%> (-1.46%) ⬇️
state/executor.go 71.29% <66.66%> (ø)
store/store.go 65.78% <68.75%> (-2.27%) ⬇️
rpc/json/service.go 65.64% <0.00%> (+1.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47f481b...9113e69. Read the comment docs.

@tzdybal tzdybal force-pushed the tzdybal/state_serialization branch 3 times, most recently from ad00e02 to 2d3d6be Compare June 8, 2022 22:16
@tzdybal tzdybal changed the title test: reproduce state deserialization error feat: serialize state with protobuf Jun 8, 2022
@tzdybal tzdybal marked this pull request as ready for review June 8, 2022 22:19
@tzdybal tzdybal requested review from adlerjohn and liamsi as code owners June 8, 2022 22:19
@tzdybal tzdybal force-pushed the tzdybal/state_serialization branch from 2d3d6be to 19a6b36 Compare June 8, 2022 22:48
Comment thread proto/get_deps.sh Outdated
Comment thread proto/get_deps.sh Outdated
Comment thread proto/get_deps.sh Outdated
Comment thread proto/get_deps.sh Outdated
Comment thread proto/get_deps.sh Outdated
Comment thread proto/get_deps.sh Outdated
@tzdybal tzdybal requested a review from adlerjohn June 9, 2022 19:57
tzdybal added 5 commits June 9, 2022 22:21
* move `State` to `types` package
* create protobuf definition for `State`
* add `FromProto` and `ToProto` methods
* fill validator sets in tests
@tzdybal tzdybal force-pushed the tzdybal/state_serialization branch from 7f9cbee to 9113e69 Compare June 9, 2022 20:21
Copy link
Copy Markdown
Contributor

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@tzdybal tzdybal merged commit 3c4318f into main Jun 10, 2022
@tzdybal tzdybal deleted the tzdybal/state_serialization branch June 10, 2022 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restarting Ethermint after crash panics

3 participants