Skip to content

feat: improved block submission error handling#427

Merged
tzdybal merged 1 commit intomainfrom
tzdybal/da_errors
Jun 4, 2022
Merged

feat: improved block submission error handling#427
tzdybal merged 1 commit intomainfrom
tzdybal/da_errors

Conversation

@tzdybal
Copy link
Copy Markdown
Contributor

@tzdybal tzdybal commented Jun 3, 2022

  • more detailed application level error information
  • exponential backoff for block submission
    • simple "times 2" strategy with upper limit
    • max backoff timeout is equal to block time
    • increased number of retries to 30

Resolves #423
Resolves #426

@tzdybal tzdybal requested a review from jbowen93 June 3, 2022 23:08
@tzdybal tzdybal self-assigned this Jun 3, 2022
@tzdybal tzdybal force-pushed the tzdybal/da_errors branch from 1a32d4f to 3384516 Compare June 3, 2022 23:18
@tzdybal tzdybal marked this pull request as ready for review June 3, 2022 23:20
@tzdybal tzdybal requested review from adlerjohn and liamsi as code owners June 3, 2022 23:20
@tzdybal
Copy link
Copy Markdown
Contributor Author

tzdybal commented Jun 4, 2022

Resilient like a honey-badger 🍯 🦡
2022-06-04_09:02:29_scrot

@Wondertan
Copy link
Copy Markdown
Contributor

Wondertan commented Jun 4, 2022

Edit: just saw another issue confirming this.

Code 19 in SDK means tx is already included in the mempool, right?

@tzdybal
Copy link
Copy Markdown
Contributor Author

tzdybal commented Jun 4, 2022

Right: https://github.com/cosmos/cosmos-sdk/blob/89323385043cd39283a57644e7c59c4ee4b90492/types/errors/errors.go#L76

@tzdybal tzdybal merged commit bd949ca into main Jun 4, 2022
@tzdybal tzdybal deleted the tzdybal/da_errors branch June 4, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DA Layer Submission Failures should result in incremental backoff Error information in DA submission retries not available

4 participants