Do not close channel after subscription cancellation#428
Merged
Conversation
jbowen93
force-pushed
the
jbowen93/no-close
branch
from
5f4e18d to
91d93d8
Compare
Codecov Report
@@ Coverage Diff @@
## main #428 +/- ##
==========================================
- Coverage 55.22% 55.20% -0.03%
==========================================
Files 48 48
Lines 8798 8796 -2
==========================================
- Hits 4859 4856 -3
- Misses 3188 3189 +1
Partials 751 751
Continue to review full report at Codecov.
|
tzdybal
force-pushed
the
jbowen93/no-close
branch
from
f69c043 to
b732774
Compare
Contributor
|
Rebased PR on top of current main. Closing a channel should be used for signaling, so in original code it was used incorrectly. ( |
tzdybal
approved these changes
Jul 4, 2022
tzdybal
changed the title
tzdybal
changed the title
adlerjohn
reviewed
Jul 4, 2022
tzdybal
force-pushed
the
jbowen93/no-close
branch
from
013278a to
2df6392
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.