Skip to content

Improve WebSockets error handling#434

Merged
tzdybal merged 2 commits intomainfrom
tzdybal/ws_err_handling
Jun 10, 2022
Merged

Improve WebSockets error handling#434
tzdybal merged 2 commits intomainfrom
tzdybal/ws_err_handling

Conversation

@tzdybal
Copy link
Copy Markdown
Contributor

@tzdybal tzdybal commented Jun 10, 2022 •
edited
Loading

This PR resolves multiple issues related to error handling in WebSockets.

  • even if connection upgrade return error, code tries to get remote address
  • NextReader errors should exit the read loop
  • logger is not passed to wsConn handle

Resolves: #326.

@tzdybal tzdybal requested a review from jbowen93 June 10, 2022 08:50
@tzdybal tzdybal self-assigned this Jun 10, 2022
@tzdybal tzdybal marked this pull request as ready for review June 10, 2022 08:50
@tzdybal tzdybal requested review from adlerjohn and liamsi as code owners June 10, 2022 08:50
@tzdybal tzdybal mentioned this pull request Jun 10, 2022
Closed
@adlerjohn adlerjohn added the T:bug Something isn't working label Jun 10, 2022
adlerjohn
adlerjohn approved these changes Jun 10, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦀

@tzdybal tzdybal merged commit dc1b489 into main Jun 10, 2022
@tzdybal tzdybal deleted the tzdybal/ws_err_handling branch June 10, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liamsi liamsi Awaiting requested review from liamsi

2 more reviewers

@adlerjohn adlerjohn adlerjohn approved these changes

@jbowen93 jbowen93 jbowen93 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tzdybal tzdybal

Labels

T:bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error handling in WS code is broken

3 participants

@tzdybal @adlerjohn @jbowen93