chore: move initGenesisChunks call into GetGenesisChunks

[distractedm1nd]

Resolves #470 (I think?)

Should the error handling from initGenesisChunks be kept inside GetGenesisChunks, or be passed to GenesisChunked ?

[tzdybal]

Error should be propagated to GenesisChunked.

[codecov-commenter]

Codecov Report

Merging #473 (9550cf2) into main (5e77f68) will decrease coverage by 0.01%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main     #473      +/-   ##
==========================================
- Coverage   55.17%   55.15%   -0.02%     
==========================================
  Files          48       48              
  Lines        8799     8802       +3     
==========================================
  Hits         4855     4855              
- Misses       3191     3193       +2     
- Partials      753      754       +1     

Impacted Files	Coverage Δ
rpc/client/client.go	45.94% <25.00%> (-0.67%)	⬇️
node/node.go	65.32% <50.00%> (+1.50%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

[adlerjohn]

Can the documentation around the three affected functions be improved here? It's not obvious to be how they differ:

1. returns chunked version of genesis.
2. returns given chunk of genesis.

You really wouldn't be able to tell these two descriptions apart were it not for the parameter, but what the functions do is completely different. What are their assumptions around initialization, what are they parameters and return values, etc.

[adlerjohn]

Stylistic nit, but would prefer explicitly handling the error case here.

[distractedm1nd]

Ok, @tzdybal prefers the other way - which way should I take?

[distractedm1nd]

Or did I misunderstand something about how the error should be handled 😅

[adlerjohn]

Oh I meant instead of returning return n.genChunks, err, return return n.genChunks, nil and do an explicit

if err != nil {
    return nil, err
}

before that.