Conversation
tzdybal
force-pushed
the
tzdybal/commit_gossiping
branch
from
7b3404d to
cf9367a
Compare
tzdybal
force-pushed
the
tzdybal/use_last_commit
branch
6 times, most recently
from
3432668 to
c596d41
Compare
Wondertan
reviewed
Aug 24, 2022
tzdybal
force-pushed
the
tzdybal/use_last_commit
branch
from
c596d41 to
8623135
Compare
tzdybal
force-pushed
the
tzdybal/use_last_commit
branch
from
8623135 to
358bf20
Compare
Wondertan
approved these changes
Sep 8, 2022
| return fmt.Errorf("failed to save block responses: %w", err) | ||
| } | ||
|
|
||
| if m.daHeight > newState.DAHeight { |
Contributor
There was a problem hiding this comment.
Was that a bug you accidentally caught? 😁
Comment on lines
+237
to
+241
| // trySyncNextBlock tries to progress one step (one block) in sync process. | ||
| // | ||
| // To be able to apply block and height h, we need to have its Commit. It is contained in block at height h+1. | ||
| // If block at height h+1 is not available, value of last gossiped commit is checked. | ||
| // If commit for block h is available, we proceed with sync process, and remove synced block from sync cache. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Resolves #484.