Conversation
Codecov Report
@@ Coverage Diff @@
## main #503 +/- ##
=======================================
Coverage 56.09% 56.09%
=======================================
Files 50 50
Lines 9279 9279
=======================================
Hits 5205 5205
Misses 3314 3314
Partials 760 760
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| revive: | ||
| rules: | ||
| - name: package-comments | ||
| disabled: true No newline at end of file |
There was a problem hiding this comment.
Can you clean up this last line? Weird that the red thing is on a different line. Perhaps a Windows/Unix newline thing?
There was a problem hiding this comment.
Changes pushed, and IDE settings corrected. 👍
tzdybal
force-pushed
the
tzdybal/libp2p
branch
from
5876e15 to
38ac48b
Compare
Wondertan
left a comment
Wondertan
left a comment
There was a problem hiding this comment.
Sweet, I saw how they were cleaning up dependencies, but now that's visible on the go.sum. libp2p becomes lightweight now
Changes themselves look good, and I don't see anything wrong. The libp2p update is mostly about moving stuff back and forth with some chores.
Another recently changed is the default identity keys, which are now ed25565 by default rather than RSA. If you explicitly use ed25562 in the libp2p.Host construction, then everything is fine
4 participants
This PR updates
go-libp2p,go-libp2p-pubsubandgo-libp2p-kad-dhtto the latest versions.Resolves #502.