Skip to content

Update data_layer_height to da_height#519

Merged
nashqueue merged 2 commits intomainfrom
refactor
Sep 9, 2022
Merged

Update data_layer_height to da_height#519
nashqueue merged 2 commits intomainfrom
refactor

Conversation

@nashqueue
Copy link
Copy Markdown
Contributor

Resolves: #345

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 8, 2022

Codecov Report

Merging #519 (e475c23) into main (41d5cc3) will decrease coverage by 0.39%.
The diff coverage is 73.91%.

@@            Coverage Diff             @@
##             main     #519      +/-   ##
==========================================
- Coverage   56.09%   55.69%   -0.40%     
==========================================
  Files          50       50              
  Lines        9279     9555     +276     
==========================================
+ Hits         5205     5322     +117     
- Misses       3314     3438     +124     
- Partials      760      795      +35     
Impacted Files Coverage Δ
types/pb/dalc/dalc.pb.go 38.78% <60.00%> (ø)
da/grpc/grpc.go 73.13% <100.00%> (ø)
da/grpc/mockserv/mockserv.go 82.35% <100.00%> (ø)
da/mock/mock.go 79.54% <100.00%> (ø)
types/validation.go 36.36% <0.00%> (-8.09%) ⬇️
types/serialization.go 66.28% <0.00%> (-3.21%) ⬇️
node/node.go 60.82% <0.00%> (-0.29%) ⬇️
types/pb/optimint/optimint.pb.go 40.29% <0.00%> (+0.01%) ⬆️
block/manager.go 62.88% <0.00%> (+0.52%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Copy Markdown
Contributor

@tzdybal tzdybal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use: [(gogoproto.customname) = "DAHeight"] in proto file, to avoid strange capitalization (DaHeight).

You'll also need add import "gogoproto/gogo.proto"; on top of the file.

See: https://github.com/tendermint/tendermint/v0.34.14/proto/tendermint/p2p/types.proto

Comment thread proto/dalc/dalc.proto Outdated
Copy link
Copy Markdown
Contributor

@tzdybal tzdybal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nashqueue nashqueue enabled auto-merge (squash) September 9, 2022 09:19
@nashqueue nashqueue merged commit 7571cf0 into main Sep 9, 2022
@nashqueue nashqueue deleted the refactor branch September 9, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename data_layer_height to da_height in DALC proto defitnitions

3 participants