Update for cosmos-sdk v0.46.1 compatibility#536
Conversation
Codecov Report
@@ Coverage Diff @@
## main #536 +/- ##
==========================================
- Coverage 55.81% 55.76% -0.06%
==========================================
Files 50 50
Lines 9555 9544 -11
==========================================
- Hits 5333 5322 -11
Misses 3428 3428
Partials 794 794
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
docker-build will not work until optimint-enabled-cosmos-sdk is updated. |
| "github.com/libp2p/go-libp2p/core/crypto" | ||
| "go.uber.org/multierr" | ||
|
|
||
| abcicli "github.com/tendermint/tendermint/abci/client" |
There was a problem hiding this comment.
Nit: I don't like the abbreviation abcicli as it makes me think it's related to a command line interface (CLI). I'd prefer either abciclient
There was a problem hiding this comment.
If following strict Go style we could also use ac
There was a problem hiding this comment.
For some reason I thought it's the way it is used in cosmos-sdk... but it's not, so I fixed to abciclient.
tzdybal
force-pushed
the
tzdybal/cosmos_0.46.x
branch
from
9957680 to
2f817f3
Compare
| @@ -1,11 +1,11 @@ | |||
| FROM --platform=$BUILDPLATFORM golang:1.17-alpine AS build-env | |||
| FROM --platform=$BUILDPLATFORM golang:1.19-alpine AS build-env | |||
There was a problem hiding this comment.
Shouldn't we consistently use the same go version here as in go.mod?
There was a problem hiding this comment.
go directive from go.mod is defined as:
The minimum version of Go required to compile packages in this module.
I'm not sure what is the actual minimal version TBH (will check this out). Code-wise I don't think there are any cases prohibiting older Go versions.
I used latest version for CI, just because it's latest available.
| return nil, fmt.Errorf("error starting proxy app connections: %w", err) | ||
| } | ||
|
|
||
| func NewNode(ctx context.Context, conf config.NodeConfig, p2pKey crypto.PrivKey, signingKey crypto.PrivKey, appClient abcicli.Client, genesis *tmtypes.GenesisDoc, logger log.Logger) (*Node, error) { |
There was a problem hiding this comment.
Nit: I would recommend line-breaks per param here.
tzdybal
force-pushed
the
tzdybal/cosmos_0.46.x
branch
from
57a8fda to
eb7dbee
Compare
tzdybal
force-pushed
the
tzdybal/cosmos_0.46.x
branch
from
eb7dbee to
5e17592
Compare
4 participants
Resolves #529.