Skip to content

Use context in integration test#539

Merged
tzdybal merged 2 commits intomainfrom
tzdybal/ctx_in_tests
Sep 26, 2022
Merged

Use context in integration test#539
tzdybal merged 2 commits intomainfrom
tzdybal/ctx_in_tests

Conversation

@tzdybal
Copy link
Copy Markdown
Contributor

@tzdybal tzdybal commented Sep 26, 2022

Using cancelable context in integration tests allows proper shutdown of nodes.

Resolves #531.

@tzdybal tzdybal requested review from adlerjohn and liamsi September 26, 2022 10:52
@tzdybal tzdybal self-assigned this Sep 26, 2022
@tzdybal tzdybal requested a review from jbowen93 September 26, 2022 10:59
Copy link
Copy Markdown
Contributor

@jbowen93 jbowen93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tzdybal tzdybal merged commit 3e0fd8d into main Sep 26, 2022
@tzdybal tzdybal deleted the tzdybal/ctx_in_tests branch September 26, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Data race in test - pubsub related

2 participants