pass logger config to mockserver#553
Merged
tzdybal merged 1 commit intoevstack:mainfrom Oct 13, 2022
Merged
Conversation
tzdybal
approved these changes
Oct 11, 2022
Contributor
tzdybal
left a comment
tzdybal
left a comment
There was a problem hiding this comment.
Thanks for your submission!
Usually logger is passed as last argument in our codebase, but it doesn't really matter.
randomshinichi
force-pushed
the
passloggerconfig
branch
from
4fe69bc to
149c9ed
Compare
Contributor
Author
|
tzdybal
reviewed
Oct 12, 2022
Contributor
tzdybal
left a comment
tzdybal
left a comment
There was a problem hiding this comment.
Thanks for taking a time to fix the nit-pick comment.
There is one tiny issue with imports, I'll update linter to automatically catch such cases.
| } | ||
| log.Println("Listening on:", lis.Addr()) | ||
| srv := mockserv.GetServer(kv, conf, nil) | ||
| srv := mockserv.GetServer(kv, conf, nil, logger) |
| grpcda "github.com/celestiaorg/rollmint/da/grpc" | ||
| "github.com/celestiaorg/rollmint/da/grpc/mockserv" | ||
| "github.com/celestiaorg/rollmint/store" | ||
| tmlog "github.com/tendermint/tendermint/libs/log" |
Contributor
There was a problem hiding this comment.
This is mixing "local" and 3rd party imports. tmlog should be imported in separate "section" before all the rollmint imports.
This should be detected by linter.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #363