Update build to replace correct module#561
Merged
tzdybal merged 1 commit intoevstack:mainfrom Oct 27, 2022
Merged
Conversation
joroshiba
force-pushed
the
optimint-rollmint-broked
branch
from
51c82d6 to
bc01554
Compare
tzdybal
approved these changes
Oct 21, 2022
Contributor
tzdybal
left a comment
tzdybal
left a comment
There was a problem hiding this comment.
Thanks for the submission!
LGTM for now. For future, we need to properly update ethermint.
jbowen93
approved these changes
Oct 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ethermint currently imports optimint, so this replace is replacing an unused module currently, testing in rollmint that ethermint works with a specific optimint version.
Update the edit so build tests what it should.