Skip to content

new rollmint dependency graph#609

Merged
nashqueue merged 5 commits intomainfrom
depedency-graph
Nov 29, 2022
Merged

new rollmint dependency graph#609
nashqueue merged 5 commits intomainfrom
depedency-graph

Conversation

@nashqueue
Copy link
Copy Markdown
Contributor

@nashqueue nashqueue commented Nov 16, 2022

Overview

Closes #605, closes #606

rendered

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 16, 2022

Codecov Report

Merging #609 (09ea3ac) into main (3a518be) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #609   +/-   ##
=======================================
  Coverage   55.46%   55.46%           
=======================================
  Files          50       50           
  Lines       10285    10285           
=======================================
  Hits         5705     5705           
+ Misses       3719     3718    -1     
- Partials      861      862    +1     
Impacted Files Coverage Δ
block/manager.go 67.26% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nashqueue nashqueue marked this pull request as ready for review November 24, 2022 13:35
@nashqueue nashqueue requested a review from tzdybal as a code owner November 24, 2022 13:35
@nashqueue nashqueue added the T:documentation Improvements or additions to documentation label Nov 24, 2022
@tzdybal tzdybal requested review from a team, S1nus and gupadhyaya and removed request for a team November 24, 2022 15:36
Copy link
Copy Markdown
Contributor

@tzdybal tzdybal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • transparent background doesn't work well with dark github theme ;)
  • Specification is the only capitalized directory name in repository - can we lowercase it?
  • please add a link to rollmint-dependency-graph.md in readme

@nashqueue nashqueue requested a review from tzdybal November 25, 2022 13:04
@nashqueue nashqueue enabled auto-merge (squash) November 25, 2022 15:30
Copy link
Copy Markdown
Contributor

@tzdybal tzdybal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nashqueue nashqueue merged commit f8be39d into main Nov 29, 2022
@nashqueue nashqueue deleted the depedency-graph branch November 29, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T:documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Links to Epics to the dependency graph svg Add Rollmint dependency graph as a draw.io svg file in a Markdown file

4 participants