Skip to content

Add Chain ID onto the Rollmint block#649

Merged
tzdybal merged 4 commits intoevstack:mainfrom
astriaorg:joroshiba/chain-id
Dec 16, 2022
Merged

Add Chain ID onto the Rollmint block#649
tzdybal merged 4 commits intoevstack:mainfrom
astriaorg:joroshiba/chain-id

Conversation

@joroshiba
Copy link
Copy Markdown
Contributor

@joroshiba joroshiba commented Dec 6, 2022

Resolves #648

Tested using gist in above issue, outcome after fix:

❯ forge create BlockTest --private-key=$PRIV_KEY
[⠆] Compiling...
No files changed, compilation skipped
Deployer: 0xa3DA60D1807b2B9e26dBFe52B0a28Ab33b4c35bf
Deployed to: 0xa190621dc3745aF6e2361F829B5E9556Ec8465C7
Transaction hash: 0x34c162af064791821b4b75caf0ed1170806b936bc3dd490109c9fcb09c56f023
❯ export CON_ADDR=0xa190621dc3745aF6e2361F829B5E9556Ec8465C7
❯ cast call $CON_ADDR "retrieve(uint256)" 3 | cast --to-ascii
 WBlock #: 3 Blockhash:0x985355a1656c68cffbec996d2b447e90b51c4d3876f4487cd84d9f53f0f59f89
❯ cast block 3 hash
0x985355a1656c68cffbec996d2b447e90b51c4d3876f4487cd84d9f53f0f59f89
❯ cast block 0x985355a1656c68cffbec996d2b447e90b51c4d3876f4487cd84d9f53f0f59f89 number
3

@joroshiba joroshiba requested a review from tzdybal as a code owner December 6, 2022 01:22
@tzdybal
Copy link
Copy Markdown
Contributor

tzdybal commented Dec 6, 2022

Good catch 👍

You need to rebase on main and re-run ./proto/get_deps.sh and ./proto/gen.sh to re-generate rollmint.pb.go file.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 6, 2022

Codecov Report

Merging #649 (28ab7f4) into main (d5e63f9) will decrease coverage by 0.15%.
The diff coverage is 55.76%.

@@            Coverage Diff             @@
##             main     #649      +/-   ##
==========================================
- Coverage   55.59%   55.44%   -0.16%     
==========================================
  Files          50       50              
  Lines       10301    10353      +52     
==========================================
+ Hits         5727     5740      +13     
- Misses       3714     3742      +28     
- Partials      860      871      +11     
Impacted Files Coverage Δ
types/pb/rollmint/rollmint.pb.go 40.02% <50.00%> (+0.20%) ⬆️
conv/abci/block.go 94.33% <100.00%> (+0.10%) ⬆️
state/executor.go 69.02% <100.00%> (-0.66%) ⬇️
types/hashing.go 100.00% <100.00%> (ø)
types/serialization.go 69.18% <100.00%> (+0.19%) ⬆️
types/validation.go 36.36% <0.00%> (-13.64%) ⬇️
block/manager.go 67.07% <0.00%> (-1.74%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@joroshiba
Copy link
Copy Markdown
Contributor Author

Good catch 👍

You need to rebase on main and re-run ./proto/get_deps.sh and ./proto/gen.sh to re-generate rollmint.pb.go file.

Done

Comment thread types/serialization.go Outdated
@tzdybal tzdybal requested review from a team, Manav-Aggarwal, S1nus and gupadhyaya and removed request for a team and S1nus December 15, 2022 14:42
@tzdybal tzdybal enabled auto-merge (squash) December 15, 2022 19:58
@tzdybal tzdybal merged commit 9df643f into evstack:main Dec 16, 2022
@joroshiba joroshiba deleted the joroshiba/chain-id branch January 10, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cosmos header hashes from app state do not exist in Rollmint

4 participants