Skip to content

Fix commit nil issue#655

Merged
Manav-Aggarwal merged 1 commit intomainfrom
manav/fix_commit_issue
Dec 12, 2022
Merged

Fix commit nil issue#655
Manav-Aggarwal merged 1 commit intomainfrom
manav/fix_commit_issue

Conversation

@Manav-Aggarwal
Copy link
Copy Markdown
Member

@Manav-Aggarwal Manav-Aggarwal commented Dec 7, 2022

Overview

Fix uninitialized commit issue during SaveBlock in publishBlock

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@Manav-Aggarwal Manav-Aggarwal self-assigned this Dec 7, 2022
@Manav-Aggarwal Manav-Aggarwal linked an issue Dec 7, 2022 that may be closed by this pull request
@Manav-Aggarwal Manav-Aggarwal marked this pull request as ready for review December 7, 2022 23:40
@Manav-Aggarwal Manav-Aggarwal enabled auto-merge (squash) December 7, 2022 23:41
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #655 (092c9fb) into main (653d4bf) will increase coverage by 0.15%.
The diff coverage is 55.00%.

@@            Coverage Diff             @@
##             main     #655      +/-   ##
==========================================
+ Coverage   55.37%   55.52%   +0.15%     
==========================================
  Files          50       50              
  Lines       10293    10301       +8     
==========================================
+ Hits         5700     5720      +20     
+ Misses       3728     3719       -9     
+ Partials      865      862       -3     
Impacted Files Coverage Δ
block/manager.go 67.07% <55.00%> (+0.16%) ⬆️
state/executor.go 69.68% <0.00%> (+0.73%) ⬆️
rpc/json/ws.go 61.90% <0.00%> (+7.93%) ⬆️
types/validation.go 50.00% <0.00%> (+13.63%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Copy Markdown
Contributor

@gupadhyaya gupadhyaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@tzdybal tzdybal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Manav-Aggarwal Manav-Aggarwal merged commit d004a92 into main Dec 12, 2022
@Manav-Aggarwal Manav-Aggarwal deleted the manav/fix_commit_issue branch December 12, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix uninitialized commit issue during SaveBlock in publishBlock

4 participants