Skip to content

feat: celestia DA: support fees#666

Merged
tzdybal merged 2 commits intomainfrom
tzdybal/fees
Dec 20, 2022
Merged

feat: celestia DA: support fees#666
tzdybal merged 2 commits intomainfrom
tzdybal/fees

Conversation

@tzdybal
Copy link
Copy Markdown
Contributor

@tzdybal tzdybal commented Dec 16, 2022

Overview

Resolves #668.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@tzdybal tzdybal self-assigned this Dec 16, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 16, 2022

Codecov Report

Merging #666 (e3c22c6) into main (9697a0f) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #666      +/-   ##
==========================================
+ Coverage   55.45%   55.52%   +0.07%     
==========================================
  Files          50       50              
  Lines       10353    10353              
==========================================
+ Hits         5741     5749       +8     
+ Misses       3741     3736       -5     
+ Partials      871      868       -3     
Impacted Files Coverage Δ
da/celestia/celestia.go 50.00% <100.00%> (ø)
block/manager.go 67.07% <0.00%> (+1.98%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tzdybal tzdybal marked this pull request as ready for review December 19, 2022 21:19
@tzdybal tzdybal requested review from a team, Manav-Aggarwal, gupadhyaya and nashqueue and removed request for a team December 19, 2022 21:19
Copy link
Copy Markdown
Member

@Manav-Aggarwal Manav-Aggarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tzdybal tzdybal merged commit 9babfad into main Dec 20, 2022
@tzdybal tzdybal deleted the tzdybal/fees branch December 20, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Celestia DA - support fees

4 participants