Skip to content

Rebrand to Rollkit#703

Merged
tzdybal merged 4 commits intomainfrom
tzdybal/rollkit_rebrand
Jan 23, 2023
Merged

Rebrand to Rollkit#703
tzdybal merged 4 commits intomainfrom
tzdybal/rollkit_rebrand

Conversation

@tzdybal
Copy link
Copy Markdown
Contributor

@tzdybal tzdybal commented Jan 22, 2023

I'm not going to fix docker workflows right now, as we should reassess their usage anyways..

Resolves #704.

@tzdybal tzdybal requested review from a team and nashqueue January 22, 2023 21:13
@tzdybal tzdybal self-assigned this Jan 22, 2023
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 22, 2023

Codecov Report

Base: 54.59% // Head: 54.64% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (1caef59) compared to base (018e42a).
Patch coverage: 52.54% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #703      +/-   ##
==========================================
+ Coverage   54.59%   54.64%   +0.04%     
==========================================
  Files          52       52              
  Lines       10372    10356      -16     
==========================================
- Hits         5663     5659       -4     
+ Misses       3840     3832       -8     
+ Partials      869      865       -4     
Impacted Files Coverage Δ
config/config.go 88.88% <ø> (ø)
conv/addr.go 100.00% <ø> (ø)
conv/config.go 47.05% <ø> (ø)
da/celestia/celestia.go 50.00% <ø> (ø)
da/celestia/mock/server.go 49.68% <ø> (ø)
da/grpc/grpc.go 73.13% <ø> (ø)
da/mock/mock.go 73.75% <ø> (ø)
da/registry/registry.go 100.00% <ø> (ø)
mempool/v1/mempool.go 86.09% <ø> (ø)
node/full.go 60.43% <0.00%> (ø)
... and 26 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tzdybal tzdybal requested review from a team, MSevey and tuxcanfly and removed request for a team January 22, 2023 21:28
@tzdybal tzdybal force-pushed the tzdybal/rollkit_rebrand branch from 7492cb7 to 9f5b03d Compare January 22, 2023 21:35
@tzdybal tzdybal force-pushed the tzdybal/rollkit_rebrand branch from 9f5b03d to 1caef59 Compare January 22, 2023 21:47
Copy link
Copy Markdown
Contributor

@nashqueue nashqueue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread .github/workflows/docker-build-ethermint-debug.yml
Copy link
Copy Markdown
Contributor

@gupadhyaya gupadhyaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tzdybal tzdybal merged commit 567b9f5 into main Jan 23, 2023
@tzdybal tzdybal deleted the tzdybal/rollkit_rebrand branch January 23, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename to Rollkit in files

4 participants