Skip to content

Add IsRunning and Stop methods to Node interface#714

Merged
Manav-Aggarwal merged 2 commits intomainfrom
manav/add_isStop_IsRunning
Jan 24, 2023
Merged

Add IsRunning and Stop methods to Node interface#714
Manav-Aggarwal merged 2 commits intomainfrom
manav/add_isStop_IsRunning

Conversation

@Manav-Aggarwal
Copy link
Copy Markdown
Member

@Manav-Aggarwal Manav-Aggarwal commented Jan 24, 2023

Closes: #705

@Manav-Aggarwal Manav-Aggarwal linked an issue Jan 24, 2023 that may be closed by this pull request
@Manav-Aggarwal Manav-Aggarwal changed the title Add IsRunning and Stop to node interface Add IsRunning and Stop methods to Node interface Jan 24, 2023
@Manav-Aggarwal Manav-Aggarwal self-assigned this Jan 24, 2023
@Manav-Aggarwal Manav-Aggarwal marked this pull request as ready for review January 24, 2023 21:20
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Base: 54.59% // Head: 54.75% // Increases project coverage by +0.15% 🎉

Coverage data is based on head (4ab7658) compared to base (018e42a).
Patch coverage: 53.52% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #714      +/-   ##
==========================================
+ Coverage   54.59%   54.75%   +0.15%     
==========================================
  Files          52       52              
  Lines       10372    10363       -9     
==========================================
+ Hits         5663     5674      +11     
+ Misses       3840     3824      -16     
+ Partials      869      865       -4     
Impacted Files Coverage Δ
config/config.go 88.88% <ø> (ø)
conv/addr.go 100.00% <ø> (ø)
conv/config.go 47.05% <ø> (ø)
da/celestia/celestia.go 50.00% <ø> (ø)
da/celestia/mock/server.go 49.68% <ø> (ø)
da/grpc/grpc.go 73.13% <ø> (ø)
da/mock/mock.go 73.75% <ø> (ø)
da/registry/registry.go 100.00% <ø> (ø)
mempool/v1/mempool.go 86.09% <ø> (ø)
node/full.go 60.43% <0.00%> (ø)
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Collaborator

@tuxcanfly tuxcanfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@Manav-Aggarwal Manav-Aggarwal enabled auto-merge (squash) January 24, 2023 21:53
@Manav-Aggarwal Manav-Aggarwal merged commit ff172bb into main Jan 24, 2023
@Manav-Aggarwal Manav-Aggarwal deleted the manav/add_isStop_IsRunning branch January 24, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add IsRunning and Stop methods to Node interface

4 participants